Note on porting 7.4.2057 and .2055 #5081

Open
ZyX-I opened this Issue Jul 17, 2016 · 5 comments

Projects

None yet

2 participants

@ZyX-I
Contributor
ZyX-I commented Jul 17, 2016

If ported, it should be src/nvim/eval/list.c, not src/nvim/list.c, also list definitions are to be moved to eval/list.h. (Same for dictionaries.)

Though I once wanted to move most of the typval_T-related stuff to src/nvim/eval/typval.{c,h}, not split them per-type. Specifically, what Bram moved to list.c and dict.c, clear_tv, GC, probably something else found after inspecting what is left.

@ZyX-I ZyX-I added the entry-level label Jul 17, 2016
@ZyX-I
Contributor
ZyX-I commented Jul 17, 2016

Actually second paragraph is a question whether 2057 and 2055 are to be ported or my variant should be accepted instead.

@ZyX-I
Contributor
ZyX-I commented Jul 17, 2016

Also 2058.

@ZyX-I
Contributor
ZyX-I commented Jul 18, 2016

2063 (that splits internal functions) is not the case, but it should be eval/funcs.{c,h}. Though I found it moves tv_islocked somewhere which should belong to eval/typval.c… Guess no patches should be ported (automatically, I mean), refactoring should be redone instead.

@ZyX-I
Contributor
ZyX-I commented Jul 24, 2016

I am currently doing refactoring and have a different plan:

  • eval/typval: base typval_T manipulations
  • eval/executor: ex_eval plus functions like ex_let which for some reason live in eval.c.
  • eval/expressions: evalN functions. To be replaced with implementation that is based on similar file from luaviml branch.
  • eval/gc: GC, obviously.

To be completed in a number of PRs.

Ping @justinmk

@justinmk
Member

@ZyX-I Completely fine with me.

@justinmk justinmk added this to the 0.3 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment