Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using FZF turns off `relativenumber` #6204

Closed
raichoo opened this issue Mar 2, 2017 · 6 comments
Closed

Using FZF turns off `relativenumber` #6204

raichoo opened this issue Mar 2, 2017 · 6 comments
Labels

Comments

@raichoo
Copy link
Contributor

@raichoo raichoo commented Mar 2, 2017

  • nvim --version: v0.2.0-747-g286aacb2
  • Vim (version: ) behaves differently? N/A
  • Operating system/version: Archlinue
  • Terminal name/version: gnome-terminal
  • $TERM: gnome-256color

Actual behaviour

Using FZF turns of the relativenumber setting in the buffer I'm currently working in.

Expected behaviour

That should not happen.

Steps to reproduce using the following configuration

call plug#begin('~/.nvim/plugged')

Plug 'junegunn/fzf', { 'dir': '~/.fzf', 'do': './install --all' }
Plug 'junegunn/fzf.vim'

call plug#end()

set number
set relativenumber
  • load a file
  • issue :Files command
  • exit FZF window using ESC
  • relative lines are now turned off

Reverting 857113c helps.

@justinmk
Copy link
Member

@justinmk justinmk commented Mar 2, 2017

Thanks for reporting.

@justinmk justinmk closed this in b62f837 Mar 2, 2017
@gkapfham
Copy link

@gkapfham gkapfham commented May 26, 2017

Hello @justinmk! Thanks for your hard work on nvim. I know that you have closed this issue. However, I am still seeing this problem with the following version of nvim on Ubuntu 16.04: NVIM v0.2.1-dev. My impression is that the fix should already be working in the version that I am running. Any updates that you could provide would be very much appreciated. Thanks again!

@justinmk justinmk reopened this May 26, 2017
@justinmk
Copy link
Member

@justinmk justinmk commented May 26, 2017

Did you exit fzf?

@gkapfham
Copy link

@gkapfham gkapfham commented May 26, 2017

Hello @justinmk! Thanks for looking into this issue.

I can confirm that if I:

  • Start nvim with set relativenumber as enabled by default
  • Confirm that relativenumber is working correctly
  • Open fzf with a command like :FZF
  • And then either exit by pressing ESC or by selecting a file

I will now see that relativenumber is no longer working for that buffer.

Please let me know if you need any more information about this issue. Thanks again for your work on nvim and your investigation of this matter.

@justinmk
Copy link
Member

@justinmk justinmk commented May 27, 2017

see #6796, now we don't modify terminal buffer-local 'number' nor 'relativenumber' at all. However 'relativenumber' is still ignored in terminal mode (i.e. "insert mode, in a terminal buffer") because it's just completely broken. But it doesn't affect the option value.

@justinmk justinmk closed this May 27, 2017
@gkapfham
Copy link

@gkapfham gkapfham commented Jun 6, 2017

Hello @justinmk! I wanted to write to thank you as this issue is now fixed when I am running NVIM v0.2.1-dev with the most recent updates on Ubuntu 16.04 LTS. Again, thanks for your work on this project --- I regularly enjoy using NeoVim on a wide variety of different projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.