Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: tui: libtermkey fork #6659

Closed
justinmk opened this issue May 3, 2017 · 5 comments
Closed

win: tui: libtermkey fork #6659

justinmk opened this issue May 3, 2017 · 5 comments

Comments

@justinmk
Copy link
Member

justinmk commented May 3, 2017

We are currently using @equalsraf fork of libtermkey. Limitations:

  • The termkey_waitkey() function is not implemented in windows, since there is no poll() alternative.

#3902 (comment)

#6315 (comment)

cc @leonerd: Would be nice to merge @equalsraf changes to libtermkey upstream. The fork is this commit.

@justinmk justinmk added this to the todo milestone May 3, 2017
@leonerd
Copy link
Contributor

leonerd commented May 3, 2017

Hrm. Mixed reaction.

I'm happy enough to make the termios stuff conditional - though personally I'd do it with

#ifdef HAVE_TERMIOS

and then conditionally set that based on not being _WIN32

A lack of termkey_waitkey is fair enough - the user will just have to provide that part by their own means. Though again I'd consider making it conditional on some actual symbol like HAVE_POLL. Also don't forget to elide it from the .h file there.

I'm not sure what's with all the newly added files; they seem to relate to cmake. Is that part of the same change? Can that not be split into a different thing somehow?

@justinmk
Copy link
Member Author

justinmk commented May 3, 2017

@leonerd Yes the cmake stuff could be split. Though we would need somewhere, so we would probably still need to maintain a fork.

@leonerd
Copy link
Contributor

leonerd commented May 3, 2017

You already maintain all the cmake stuff for nvim anyway though, so maybe that's not so bad?
I just don't feel confident in shipping/maintaining a cmake config when I know nothing about the system.

@justinmk
Copy link
Member Author

justinmk commented May 3, 2017

Sure, if we can move the cmake stuff to neovim then we will do that. @equalsraf then IIUC we wouldn't need to download the appveyor artifact, instead we would build it?

@justinmk justinmk mentioned this issue May 3, 2017
9 tasks
@equalsraf
Copy link
Contributor

Understood, I'm splitting things up then, here is the relevant commit equalsraf/libtermkey@578fe18

@leonerd I've added HAVE_TERMIOS like you suggested.

How should I ellide termkey_waitkey from termkey.h.in based on a compile time HAVE_POLL?

Full branch and appveyor builds at equalsraf/libtermkey#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants