tui + termguicolors: Text-glitches since v0.2.1 #7618
Assignees
Labels
bug-regression
wrong behavior that was introduced in a previous commit (please bisect)
display
redraw, layout, presentation
tui
Milestone
Comments
|
What does :checkhealth say in the terminal section? (Env vars) |
|
|
|
I do have the same 'problem' for a while also. It occurs most often if I create a vertical split. I'm on Fedora26, with GNOME Terminal 3.24.2 |
justinmk
added
tui
bug-regression
|
@unclechu @duikboot can you try this patch? (edit: #7624 ) diff --git a/src/nvim/tui/tui.c b/src/nvim/tui/tui.c
index 7ff426239a6e..85bf69e4aec0 100644
--- a/src/nvim/tui/tui.c
+++ b/src/nvim/tui/tui.c
@@ -902,8 +902,7 @@ static void tui_scroll(UI *ui, Integer count)
if (can_use_scroll(ui)) {
int saved_row = grid->row;
int saved_col = grid->col;
- bool scroll_clears_to_current_colour =
- unibi_get_bool(data->ut, unibi_back_color_erase);
+ bool scroll_clears_to_current_colour = false;
-
// Change terminal scroll region and move cursor to the top
if (!data->scroll_region_is_full_screen) { |
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). That's fine if the system terminfo claims to support it; but our built-in fallback should not assume it. ref kovidgoyal/kitty#160 (comment) ref neovim#4210 ref neovim#4421 closes neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). That's fine if the system terminfo claims to support it; but our built-in fallback should not assume it. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. So the built-in terminfos should disable it by default. ref neovim#4210 ref neovim#4421 closes neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). That's fine if the system terminfo claims to support it; but our built-in fallback should not assume it. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. So the built-in terminfos should disable it by default. ref neovim#4210 ref neovim#4421 closes neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). That's fine if the system terminfo claims to support it; but our built-in fallback should not assume it. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. So the built-in terminfos should disable it by default. ref neovim#4210 ref neovim#4421 ref neovim#7035 ref neovim#7337 ref neovim#7381 ref neovim#7425 closes neovim#7618
|
|
justinmk
changed the title
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). That's fine if the system terminfo claims to support it; but our built-in fallback should not assume it. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. So the built-in terminfos should disable it by default. ref neovim#4210 neovim#4421 neovim#7035 neovim#7337 neovim#7381 neovim#7425 neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 23, 2017
133ae5e implemented BCE (background color erase). It has caused a lot of trouble and gained almost nothing. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. ref neovim#4210 neovim#4421 neovim#7035 neovim#7337 neovim#7381 neovim#7425 neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Nov 24, 2017
133ae5e implemented BCE (background color erase). But we can't trust terminfo, so it is safer disable BCE if we are not certain. Per kovidgoyal/kitty#160 (comment) terminal support for BCE seems to be (1) optional and (2) inconsistent. ref neovim#4210 neovim#4421 neovim#7035 neovim#7337 neovim#7381 neovim#7425 neovim#7618
justinmk
added a commit
to justinmk/neovim
that referenced
this issue
Jan 2, 2019
Remove this vestigial hack from neovim#7624. Since 5a0d028 we blacklist BCE more surgically. And patch_terminfo_bugs() is the more appropriate place for that. ref 5749eca ref neovim#4210 neovim#4421 neovim#7035 neovim#7337 neovim#7381 neovim#7425 neovim#7618
justinmk
added a commit
that referenced
this issue
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Glitches appear on the screen (TUI) when I scroll, switch tab, and do anything that involves rerendering for many symbols of text-matrix. I reproduced it with
v0.2.1,v0.2.2and also latest nightlyv0.2.3-dev9b6bf8f. Withv0.2.0it isn't happening. Every version built from this repo by this commands:make CMAKE_EXTRA_FLAGS="-DCMAKE_INSTALL_PREFIX=/foo/bar/baz" make installTermite v12, Neovim v0.2.2:
Konsole v16.12.3, Neovim v0.2.2:
My config: https://github.com/unclechu/neovimrc/ 89cc8b9
nvim --version:v0.2.0) behaves differently?$TERM: xterm-256colorThe text was updated successfully, but these errors were encountered: