New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Remove unused argument 'defer' in function 'job_start'. #1000

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@oni-link
Copy link
Contributor

oni-link commented Jul 27, 2014

Remove unused argument defer in function job_start.

  • With the changes in commit
    "events: Refactor how event deferral is handled"
    (2e4ea29) the function argument
    defer of job_start and member variable defer of struct job
    can be removed.
  • Update/Fix the documentation for function job_start.

ping @tarruda to verify nothing else is planned for the defer member variable of struct job.

@philix

This comment has been minimized.

Copy link
Member

philix commented Jul 28, 2014

If @tarruda doesn't have any plan that uses defer, LGTM.

@aktau

This comment has been minimized.

Copy link
Member

aktau commented Jul 28, 2014

If @tarruda doesn't have any plan that uses defer, LGTM.

Same here.

@tarruda

This comment has been minimized.

Copy link
Member

tarruda commented Jul 28, 2014

Sorry, I forgot to remove this parameter. It's no longer needed after @2e4ea29

👍

@aktau aktau changed the title [RFC] Remove unused argument 'defer' in function 'job_start'. [RDY] Remove unused argument 'defer' in function 'job_start'. Jul 28, 2014

@aktau aktau changed the title [RDY] Remove unused argument 'defer' in function 'job_start'. [RFC] Remove unused argument 'defer' in function 'job_start'. Jul 28, 2014

@aktau

This comment has been minimized.

Copy link
Member

aktau commented Jul 28, 2014

Alright then. If you tag RDY I'll merge it @oni-link.

@aktau

This comment has been minimized.

Copy link
Member

aktau commented Jul 28, 2014

Also congratulations to ourselves for the 1000'th PR ;).

@oni-link oni-link changed the title [RFC] Remove unused argument 'defer' in function 'job_start'. [RDY] Remove unused argument 'defer' in function 'job_start'. Jul 28, 2014

@aktau

This comment has been minimized.

Copy link
Member

aktau commented Jul 29, 2014

Can't merge as-is @oni-link, could you rebase on master?

Remove unused argument 'defer' in function 'job_start'.
* With the changes in commit
  "events: Refactor how event deferral is handled"
  (2e4ea29) the function argument
  'defer' of 'job_start' and member variable 'defer' of 'struct job'
  can be removed.
* Update/Fix the documentation for function 'job_start'.
@oni-link

This comment has been minimized.

Copy link
Contributor

oni-link commented Jul 29, 2014

@aktau, rebased on master. Removed unused job_start argument in function os_system.

aktau added a commit that referenced this pull request Jul 29, 2014

Remove unused arg 'defer' in 'job_start' #1000
* With the changes in commit
  "events: Refactor how event deferral is handled"
  (2e4ea29) the function argument
  'defer' of 'job_start' and member variable 'defer' of 'struct job'
  can be removed.
* Update/Fix the documentation for function 'job_start'.
@aktau

This comment has been minimized.

Copy link
Member

aktau commented Jul 29, 2014

Perfect, merged.

@aktau aktau closed this Jul 29, 2014

@justinmk justinmk added the refactor label Jul 29, 2014

fmoralesc added a commit to fmoralesc/neovim that referenced this pull request Aug 19, 2014

Remove unused arg 'defer' in 'job_start' neovim#1000
* With the changes in commit
  "events: Refactor how event deferral is handled"
  (2e4ea29) the function argument
  'defer' of 'job_start' and member variable 'defer' of 'struct job'
  can be removed.
* Update/Fix the documentation for function 'job_start'.

dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment