use fseek instead of lseek for a file stream #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for |
mhinz
reviewed
Oct 13, 2019
mhinz
approved these changes
Oct 13, 2019
this also fixes neovim#11196 as using lseek leads to file system misbehaviour on osx Catalina
dm1try
force-pushed
the
fix_fs_misbehaviour_on_catalina
branch
from
aa29b3f
to
319c69a
Compare
|
Thanks for digging into this, @dm1try! |
|
Thanks, cherry-picked to the release branch in a1f5576. |
|
@mhinz, thanks for the collaboration) |
That should be in the commit message next time :) |
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Nov 6, 2019
Maintenance release for the v0.4.x series. FIXES: 599ad5d Windows: nvim-qt v0.2.15 (fix "invalid font" error on startup) 1def945 neovim#11332 autocmd: Fix event name casing b678d33 neovim#11315 test: delete duplicate highlight group 924fa14 neovim#11225 ex_echo: fix check for got_int 327e8dd neovim#11138 deps: pass LDFLAGS+=-static a1f5576 neovim#11222 mac: fix "tags file not sorted" bug on Catalina f2f3771 neovim#11187 recovery mode (-r/-L): use headless_mode 4f452a6 neovim#11190 Remove "highbright bold" conversion. 9571a87 neovim#11177 third-party: upgrade libvterm to 0.1.2 3817518 neovim#11074 terminfo_start: flush buffer 56d9412 win_line: update `w_last_cursorline` always ddd3363 neovim#11132 patch_terminfo_bugs: TERM=xterm with non-xterm: ignore smglr d453d2c Fix redraw regression with w_p_cole in visual mode e0622b4 screen: missing redraw/highlight for ruler in message area b781f2b cmdline: wildmenumode() should be true with wildoptions+=pum eef3809 neovim#11027 win_update: fix redraw regression 43f4955 neovim#11069 Merge pull request from bfredl/virtualcol 6f693be neovim#11050 env: use putenv_s for LC_ALL, LANG, etc. 36e2846 neovim#11094 paste: fix handling of "<" in cmdline 60b56ed neovim#11126 Merge pull request from bfredl/invalidcell-0.4 8250d67 screen: don't crash on invalid grid cells being recomposed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also fixes #11196 as using lseek leads to file system misbehaviour on osx Catalina