New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Remove `~` after end-of-line #1214

Closed
wants to merge 20 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@mhinz
Member

mhinz commented Sep 21, 2014

Hey,

this replaces the ~ shown after the last line in the file by a space.

I'd argue that this character is rather useless and many people either just put up with it or change the NonText highlight group so that foreground and background have the same color. But the problem with the latter solution is that NonText also gets used for some characters from the 'listchars' option where it would be useful to actually see them.. :-)

Alternatively, one could create an own highlight group for it.

I'm not sure how compatible you'd like to stay with Vim, but this always bugged me somehow:

http://i.imgur.com/q2EEFoo.png

p.s. At the moment the fold and sign columns get continued after the last line, too. I could patch them out, if wanted. IMHO there's no reason to show anything after the end of the actual file.

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Sep 21, 2014

Member

Welcome back :) If you are ok with the Apache 2.0 license for your past work, would you mind signing the CLA?

Regarding this PR, I think it could make sense if we offered some other way to visually indicate EOF. The ~ column is redundant if line numbers are enabled, otherwise this could be regarded as a loss of functionality. Maybe NonText should default to some other color?

Somehow these tests are failing:

test_listlbr FAILED
test_listlbr_utf8 FAILED

Member

justinmk commented Sep 21, 2014

Welcome back :) If you are ok with the Apache 2.0 license for your past work, would you mind signing the CLA?

Regarding this PR, I think it could make sense if we offered some other way to visually indicate EOF. The ~ column is redundant if line numbers are enabled, otherwise this could be regarded as a loss of functionality. Maybe NonText should default to some other color?

Somehow these tests are failing:

test_listlbr FAILED
test_listlbr_utf8 FAILED

@mhinz

This comment has been minimized.

Show comment
Hide comment
@mhinz

mhinz Sep 21, 2014

Member

If you are ok with the Apache 2.0 license for your past work, would you mind signing the CLA?

Done!

The ~ column is redundant if line numbers are enabled, otherwise this could be regarded as a loss of functionality.

I agree. It should be visualized somehow, but it should also be configurable. So the other options would be:

1) adding another highlight group exclusively for the ~
2) adding another option for that character, so that it can be set to a space

Any other idea how to visualize the EOF?

Member

mhinz commented Sep 21, 2014

If you are ok with the Apache 2.0 license for your past work, would you mind signing the CLA?

Done!

The ~ column is redundant if line numbers are enabled, otherwise this could be regarded as a loss of functionality.

I agree. It should be visualized somehow, but it should also be configurable. So the other options would be:

1) adding another highlight group exclusively for the ~
2) adding another option for that character, so that it can be set to a space

Any other idea how to visualize the EOF?

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Sep 21, 2014

Member

adding another highlight group exclusively for the ~

This seems like a good idea to me. Avoids documentation/conflicts of new options.

P.S. There is one little step left in the email you should have received from the CLA form.

Member

justinmk commented Sep 21, 2014

adding another highlight group exclusively for the ~

This seems like a good idea to me. Avoids documentation/conflicts of new options.

P.S. There is one little step left in the email you should have received from the CLA form.

Shougo and others added some commits Sep 18, 2014

vim-patch:7.4.410
Problem:    Fold does not open after search when there is a CmdwinLeave
            autocommand.
Solution:   Restore KeyTyped. (Jacob Niehus)

https://code.google.com/p/vim/source/detail?r=v7-4-410
vim-patch:7.4.305
Problem:    Making 'ttymouse' empty after the xterm version was requested
            causes problems. (Elijah Griffin)
Solution:   Do not check for DEC mouse sequences when the xterm version was
            requested.  Also don't request the xterm version when DEC mouse
            was enabled.

https://code.google.com/p/vim/source/detail?r=v7-4-305
vim-patch:7.4.359
Problem:    When 'ttymouse' is set to 'uxterm' the xterm version is not
            requested. (Tomas Janousek)
Solution:   Do not mark uxterm as a conflict mouse and add
            resume_get_esc_sequence().

https://code.google.com/p/vim/source/detail?r=v7-4-359
vim-patch:7.4.392
Problem:    Not easy to detect type of command line window.
Solution:   Add the getcmdwintype() function. (Jacob Niehus)

https://code.google.com/p/vim/source/detail?r=v7-4-392
doc: remove reference to config.mk, hangulin.txt
needed to get `make html` to work.
doc: remove some unnecessary targets
these files got all imported, no ned to create them
doc: remove encoding conversion targets
this deletes the source files wich have an utf-8 generated file.
in the next step the generated *UTF-8.1* files will be renamed.
doc: remove uganda.nsis.txt target
It seems that this file was used in the windows installer as license
file.
doc: remove links that point nowhere
`make html` displays errors for links that are not in the tagfile
doc: use `cat` instead of `more` to display errors
`more` may cause the travis build to hang
build: install with the correct permissions
The install() command will create the parent directories, but it does so
with the user's umask.  We want to do our best to make sure the correct
permissions are being set, without clobbering existing permissions.

To do this, this commit introduces an install_helper(), which is similar
in signature to the install() command, to help ensure that directories
are created ahead of the actual install() command.  This will attempt to
use 0644 permissions for files and 0755 permissions for directories by
default--though they can be overridden.

To make this work correctly, without trying to introduce some mechanism
with setting the umask, it meant that there's a small portion that makes
use of an "internal" version of the file() command.  It has been tested
on CMake 2.8.11, 2.8.12, and 3.0.2, and works correctly on all versions.

This fixes #1201 and #1086.

@mhinz mhinz closed this Sep 22, 2014

@mhinz mhinz deleted the mhinz:remove-tilde branch Sep 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment