Add check for declaration and typeDefinition support in vim lsp server before making request
#12421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto
requested changes
Jun 2, 2020
Member
teto
left a comment
teto
left a comment
There was a problem hiding this comment.
this incondtionnaly disables typeDefinition. You need to really check for support in runtime/lua/vim/lsp/protocol.lua|863 col 19| function protocol.resolve_capabilities(server_capabilities)
Contributor
Author
|
Oh I didn't realize! I'll look into it now. |
kdheepak
changed the title
typeDefinition support in vim lsp serverdeclaration and typeDefinition support in vim lsp server before making request
Contributor
Author
|
This is working as expected for me now. This is ready for review. |
tjdevries
reviewed
Jun 2, 2020
Contributor
|
Thanks for the PR @kdheepak . Feel free to open another if you want to handle the more complicated parsing of the tables! |
Contributor
Author
|
Thank you! |
weilbith
added a commit
to weilbith/nvim-lsp-bacomp
that referenced
this pull request
Jun 18, 2020
farisachugthai
pushed a commit
to farisachugthai/neovim
that referenced
this pull request
Aug 4, 2020
…lsp server before making `request` (neovim#12421) * Add check for typeDefinition support in vim lsp server * Check for typeDefinitionProvider in server * Check for declarationProvider in server * Add check for client support * Fix typo
h-michael
pushed a commit
to h-michael/neovim
that referenced
this pull request
Aug 24, 2020
…lsp server before making `request` (neovim#12421) * Add check for typeDefinition support in vim lsp server * Check for typeDefinitionProvider in server * Check for declarationProvider in server * Add check for client support * Fix typo
landerlo
pushed a commit
to landerlo/neovim
that referenced
this pull request
Nov 23, 2020
…lsp server before making `request` (neovim#12421) * Add check for typeDefinition support in vim lsp server * Check for typeDefinitionProvider in server * Check for declarationProvider in server * Add check for client support * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required because LanguageServer.jl crashes when requesting
textDocument/typeDefinitionandtextDocument/declaration. LanguageServer.jl tells the client that it does not support this client and the client should not make this request. I've based this PR on the code fortextDocument/implementation, which does the right thing.