New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add EndOfBuffer hl group for ~ lines after the last line in buffers #1926

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@fmoralesc
Contributor

fmoralesc commented Feb 1, 2015

@fmoralesc fmoralesc changed the title from Add EndOfBuffer hl group for ~ lines after the last line in buffers to [RFC] Add EndOfBuffer hl group for ~ lines after the last line in buffers Feb 1, 2015

@marvim marvim added the RFC label Feb 1, 2015

Show outdated Hide outdated runtime/doc/syntax.txt Outdated
Show outdated Hide outdated runtime/doc/syntax.txt Outdated
@fmoralesc

This comment has been minimized.

Show comment
Hide comment
@fmoralesc

fmoralesc Feb 2, 2015

Contributor

@justinmk I added the changes. Will rebase once you are OK with them ;)

Contributor

fmoralesc commented Feb 2, 2015

@justinmk I added the changes. Will rebase once you are OK with them ;)

@@ -5781,6 +5781,7 @@ static char *(highlight_init_both[]) =
"StatusLine term=reverse,bold cterm=reverse,bold gui=reverse,bold"),
CENT("StatusLineNC term=reverse cterm=reverse",
"StatusLineNC term=reverse cterm=reverse gui=reverse"),
"default link EndOfBuffer NonText",

This comment has been minimized.

@justinmk

justinmk Feb 2, 2015

Member

Indent?

@justinmk

justinmk Feb 2, 2015

Member

Indent?

This comment has been minimized.

@fmoralesc

fmoralesc Feb 2, 2015

Contributor

It was like this in the original patch, it has the same indent as the CENT items, which are at the same structural level.

@fmoralesc

fmoralesc Feb 2, 2015

Contributor

It was like this in the original patch, it has the same indent as the CENT items, which are at the same structural level.

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Feb 2, 2015

Member

This is based on the updated vim_dev patch, right?

LGTM

Member

justinmk commented Feb 2, 2015

This is based on the updated vim_dev patch, right?

LGTM

@fmoralesc

This comment has been minimized.

Show comment
Hide comment
@fmoralesc

fmoralesc Feb 2, 2015

Contributor

Yes, this is based on the updated vim_dev patch. Just rebased.

Contributor

fmoralesc commented Feb 2, 2015

Yes, this is based on the updated vim_dev patch. Just rebased.

Add EndOfBuffer hl group for ~ lines after the last line in buffers
This makes it possible to highlight the lines starting with ~ at the end
of buffers and other elements highlighted using NonText.

As proposed by mhinz at
https://groups.google.com/forum/#!topic/vim_dev/p3de1iU1GXI/discussion
@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Feb 2, 2015

Member

merged, thanks :)

Member

justinmk commented Feb 2, 2015

merged, thanks :)

@justinmk justinmk closed this Feb 2, 2015

@justinmk justinmk removed the RFC label Feb 2, 2015

@@ -3803,7 +3802,8 @@ A jump table for the options with a short description can be found at |Q_op|.
first character in a pair gives the occasion, the second the mode to
use for that occasion. The occasions are:
|hl-SpecialKey| 8 Meta and special keys listed with ":map"
|hl-NonText| @ '~' and '@' at the end of the window and
|hl-EndOfBuffer| ~ lines after the last line in the buffer
|hl-NonText| @ '@' at the end of the window and

This comment has been minimized.

@fwalch

fwalch Feb 2, 2015

Member

I think this needs a {Nvim} and/or a mention at https://github.com/neovim/neovim/wiki/Differences-from-Vim (probably not here, though, but in syntax.txt at *hl-EndOfBuffer*, sorry). I fear that we'll get to a point where we lose track of what small feature changes such as this Neovim has compared to Vim. Maybe we're already there...

@fwalch

fwalch Feb 2, 2015

Member

I think this needs a {Nvim} and/or a mention at https://github.com/neovim/neovim/wiki/Differences-from-Vim (probably not here, though, but in syntax.txt at *hl-EndOfBuffer*, sorry). I fear that we'll get to a point where we lose track of what small feature changes such as this Neovim has compared to Vim. Maybe we're already there...

This comment has been minimized.

@justinmk

justinmk Feb 2, 2015

Member

👍

@justinmk

justinmk Feb 2, 2015

Member

👍

@ghost ghost referenced this pull request Feb 21, 2015

Merged

Upcoming Newsletter #82

22 of 22 tasks complete

@fmoralesc fmoralesc deleted the fmoralesc:endofbuffer branch Feb 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment