New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Simpler handling for "always-on"/"always-off" options. #2002

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@fwalch
Member

fwalch commented Feb 17, 2015

Current "always-off" options are compatible and edcompatible.
Updated the documentation for consistency. set ttyfast is no error anymore (but set nottyfast is).

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Feb 17, 2015

Member

👍 Good idea. Is there any way to avoid more globals? Also wondering if we can reduce the code needed in set_bool_option(). Never mind, I get it now.

Member

justinmk commented Feb 17, 2015

👍 Good idea. Is there any way to avoid more globals? Also wondering if we can reduce the code needed in set_bool_option(). Never mind, I get it now.

@marvim marvim added the RFC label Feb 17, 2015

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 17, 2015

LGTM, my previous solution wasn't exactly elegant 😄

ghost commented Feb 17, 2015

LGTM, my previous solution wasn't exactly elegant 😄

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 19, 2015

I think Travis might have been having issues when you pushed, given that everything failed. I've since rebased and repushed my PRs and they're passing... weird.

ghost commented Feb 19, 2015

I think Travis might have been having issues when you pushed, given that everything failed. I've since rebased and repushed my PRs and they're passing... weird.

@ghost ghost referenced this pull request Feb 21, 2015

Merged

Upcoming Newsletter #82

22 of 22 tasks complete
@elmart

This comment has been minimized.

Show comment
Hide comment
@elmart

elmart Feb 22, 2015

Member

LGTM.

Member

elmart commented Feb 22, 2015

LGTM.

@fwalch fwalch changed the title from [RFC] Simpler handling for "always-on"/"always-off" options. to [RDY] Simpler handling for "always-on"/"always-off" options. Feb 22, 2015

@aktau

This comment has been minimized.

Show comment
Hide comment
@aktau

aktau Feb 22, 2015

Member

Great, LGTM!

Member

aktau commented Feb 22, 2015

Great, LGTM!

Show outdated Hide outdated runtime/doc/options.txt Outdated
Show outdated Hide outdated runtime/doc/options.txt Outdated
Simpler handling for "always-on"/"always-off" options.
'compatible' and 'edcompatible' are forced to be off.
'ttyfast' is forced to be on.

justinmk added a commit that referenced this pull request Feb 22, 2015

Simpler handling for "always-on"/"always-off" options. #2002
'compatible' and 'edcompatible' are forced to be off.
'ttyfast' is forced to be on.
@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Feb 22, 2015

Member

merged, thanks!

Member

justinmk commented Feb 22, 2015

merged, thanks!

@justinmk justinmk closed this Feb 22, 2015

@justinmk justinmk removed the RFC label Feb 22, 2015

@fwalch fwalch deleted the fwalch:ttyfast-default branch Feb 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment