New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove hardcopy #21472
feat!: remove hardcopy #21472
Conversation
7493d7c
to
0fbc9ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
7745526
to
ffa2c37
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e034a4b
to
c9aede4
Compare
I don't think your last commit removed translations properly. You didn't remove the comment above them, and for some fuzzy |
my comment from last time... #15235 (comment) :
Perhaps we could alias |
f320f87
to
ea6d38c
Compare
I removed them via |
ea6d38c
to
4bc81c0
Compare
The main issue is that For reference, the default value for system(['lpr']
+ (empty(&printdevice)?[]:['-P', &printdevice])
+ [v:fname_in])
.. delete(v:fname_in)
+ v:shell_error So we could do something like: local postscript_tmp = convert_to_postscript(bufnr)
vim.fn.system({'lpr', postscript_tmp})
vim.fn.delete(postscript_tmp)
if vim.v.shell_error then
error(vim.v.shell_error)
end Also we can't easily alias The use case is so niche I'm not sure if it would be worth it instead of just suggesting to use |
ca407f6
to
8dc8285
Compare
Aliasing commands like that will age badly I think. Doing that will implicitly encode historical details that is gonna be annoying to explain. "Oh, in vim hardcopy prints out a file. In neovim, hardcopy is aliased to tohtml because this and this and that...". Finding information about hardcopy online is gonna be annoying as well, because confusions of the nature "do you mean vim hardcopy or neovim hardcopy?" will show up. |
e6e3ef9
to
e3789ba
Compare
Agreed; better to provide a new (plugin) command |
|
I think everyone is agreed that we want a rewrite of the The big question is: does that need to happen before the excision? Arguably, (Whether and how to wrap |
Let's nix it already. it is one legacy file less to be affected when doing general code refactors/quality improvements. |
What is the point of removing this from menu.vim and optwin.vim then? |
The possibility of users hitting errors when leaving it in? |
They are already guarded by |
Then we can just as well remove them. |
e3789ba
to
2f038c6
Compare
Let's get some reviews so we can make a decision. I've just had to resolve a conflict so that file is getting churn. |
2f038c6
to
b4e0afe
Compare
a2246ae
to
af7db83
Compare
Co-authored-by: Justin M. Keyes <justinkz@gmail.com>
af7db83
to
e3ded5b
Compare
Do I understand correctly that the current fallback for those of us who used this feature is to now instead use |
That's exactly the case.
so the scales tipped pretty heavily to removing it. If anyone creates a plugin for printer support, we would happily endorse it (providing it's good and works). |
I'm in favor of adding some builtin sugar that saves steps here.
Then you just hit ctrl-p to print, is that good enough? Step (2) above is the annoying part--finding and opening the file. |
No objections from me, except the remark that this means, as one of the few users, that I will need to change my workflow. No big deal - I don't print things often anyway.
Yes, for me it seems like a convenient fallback solution that I would be happy to use. |
I also use this. I'm not mad that it's been removed given the issues with tree sitter though; I have a hack script to turn it off temporarily, change colour scheme, etc to print, but this is a hack. The correct solution is some plugin rendering html then using a (possibly headless) web browser to generate a PDF. For my limited use cases I'll just use vim for it or something like https://github.com/matze/tree-painter |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The path forward for hardcopy is #21629 |
#27097 adds treesitter (and more) support to |
Revive: #15235