New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] scripts: Create script which checks Neovim with PVS-studio #6493

Merged
merged 6 commits into from Apr 16, 2017

Conversation

Projects
None yet
4 participants
@ZyX-I
Contributor

ZyX-I commented Apr 10, 2017

This variant suggests manual checks and has hardcoded version in one place. Example report: https://gist.github.com/ZyX-I/20cdeee0cd1812f85ce7afec7e909c82 (three files: I used different supported formats, yet it does not generate HTML reports).

PVS is pretty fast for an analyzer: script takes 2 minutes to run on my system and this includes compiling Neovim.

Script is here to check locally. I am unsure whether it would be right (legally and morally) to patch our sources with that comment on the fly only on CI, but script may be used to decide whether we need to include those comments in our sources and make bot-ci generate reports.

@ZyX-I

This comment has been minimized.

Contributor

ZyX-I commented Apr 10, 2017

Stopped travis build for being useless.

@ZyX-I

This comment has been minimized.

Contributor

ZyX-I commented Apr 10, 2017

When checking my gist note: all line numbers are off by two: comment added.

@marvim marvim added the RFC label Apr 10, 2017

@ZyX-I ZyX-I merged commit d4c7f74 into neovim:master Apr 16, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
QuickBuild Build pr-6493 finished with status SUCCESSFUL
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jszakmeister jszakmeister removed the RFC label Apr 16, 2017

@justinmk

This comment has been minimized.

Member

justinmk commented Apr 16, 2017

@ZyX-I Is there a "quick start" you can recommend to install pvs, or just follow some instructions found on their website somewhere?

@ZyX-I

This comment has been minimized.

Contributor

ZyX-I commented Apr 16, 2017

The script installs PVS itself. There are instructions, but they suppose you want to install PVS globally. Given that they provide static binaries this is not needed: just unpack and adjust $PATH.

@ZyX-I

This comment has been minimized.

Contributor

ZyX-I commented Apr 16, 2017

Though, of course, people with rpm or apt-get could install their archives using the package manager. I was talking only about systems (like Gentoo) where package manager does not use rpm or deb.

@justinmk

This comment has been minimized.

Member

justinmk commented Apr 16, 2017

Ok, great. I'll mention that on the wiki and link it from CONTRIBUTING.md.

Looks like https://www.viva64.com/en/m/0017/ is the way to silence false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment