Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
tui: rework deferred-termcodes implementation #7720
Try another approach to defer the termcodes.
QB failure with the non-timer approach (6b51c72 ), seems to cause a SIGABRT (134):
referenced this pull request
Dec 12, 2017
Dec 13, 2017
I tried it. This version takes considerable time until the callbacks are triggered (feels like half a second or maybe a second).
Enough time in fact to switch windows. Then, vim triggers some events and tells my window manager that vim is open and that it should switch to vim mode. Suddenly, my browser window is focussed with my window manager in vim mode and I'm confused.
Would it be possible to defer sending the request only if term=tmux?
Of course I tested it.
When testing earlier today, obviously, the first problem was averted, vim will eventually send the request.
I was however able to switch windows before the notifications got to vim, and so got into an inconsistent state because vim now thought it had the focus while it did not. This is why I wrote I'd have to remember not to switch windows immediately after starting vim.
But then, while writing this reply, I noticed that I could also avert the problem with a change of the perl code that makes urxvt send the notifications to nvim. I would therefore say that your commit fixed the second problem as well (I only noticed after I ironed out a bug in my perl code).