Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[RFC] Make terminals work with buffer updates #8616
@KillTheMule: I disabled it because it seemed like the unit tests required to prove the feature works would be complex and time consuming to make and I didn't think anyone would want buffer updates for a
Ok, the test is officially driving me nuts. It takes a whooping 30s on my machine, but everytime I try to measure something, the offending line turns out to be something different. I tried putting in early returns, that made this line seem to be 1/3 of the culprit. Then again, I've put in all these measurements via
I'm stumped. Help!
(e) Observation: This test takes 30s on appveyor as well as on travis and quickbuild. That's ... weird.
@bfredl figured it out. I was calling
We're not comparing the state of the embedded nvim's message area (that's to racy in my experience), and we're ignoring the changedtick's, which seem dependent on the redraw behavior of the embbeded nvim, which does not seem predictable between different OSes. But I think making sure that 'keeping a buffer mirror' makes you reach the expected state sometime is what can be expected here.
Question: I can shave of 100ms off the test by not quitting the embedded neovim instance properly. Should I do that?