New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix redrawing issues with narrow screen and remove extra wait in resize tests #8721

Merged
merged 2 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@bfredl
Member

bfredl commented Jul 11, 2018

Screen size is part of screen state, so treat it as such, instead of some kind of precondition for even doing screen tests.

Saves ~10 seconds in UI tests in local testing.

tests/screen.lua: treat "resize" like any other event
Saves ~10 seconds in UI tests
@bfredl

This comment has been minimized.

Member

bfredl commented Jul 11, 2018

the has minimum width/height test is very suspicious, the first expectation is clearly wrong, but it is equally wrong if 2 lines is set explicitly instead, so the bug is likely not caused by ui layer logic (intended vs actual height), rather somewhere in the screen.c layout code.

@marvim marvim added the RFC label Jul 11, 2018

@bfredl

This comment has been minimized.

Member

bfredl commented Jul 11, 2018

In general, nvim will behave erratically when modemsg doesn't fit on a line, best tried with i<c-o>v to get a modemsg significantly longer than MIN_COLUMNS.

Latest commit tries to fix it by truncating instead, changed test shows change of behavior (to the better), also this test is hopefully not in-deterministic anymore.

@bfredl bfredl force-pushed the bfredl:quickresize branch 2 times, most recently from 14951da to db51315 Jul 11, 2018

@bfredl bfredl changed the title from [RFC] tests/screen.lua: treat "resize" like any other event to [RFC] Fix redrawing issues with narrow screen and remove extra wait in resize tests Jul 11, 2018

@justinmk

This comment has been minimized.

Member

justinmk commented Jul 12, 2018

restarted appveyor, only nodejs_spec failed there. Please merge this if it's ready!

screen: truncate showmode messages
Before this, bottom of screen got messed up when modemsg (+ one extra
space to not force terminal scroll) didn't fit on one line.

@bfredl bfredl force-pushed the bfredl:quickresize branch from db51315 to e51bffe Jul 12, 2018

@bfredl

This comment has been minimized.

Member

bfredl commented Jul 12, 2018

added comment, let's run the tests once more (to check indeterminism).

@bfredl

This comment has been minimized.

Member

bfredl commented Jul 12, 2018

This one was interesting:

[----------] Running tests from /Users/travis/build/neovim/neovim/test/functional/ui/spell_spec.lua
[ RUN      ] 'spell' joins long lines #7937: ERR
test/functional/helpers.lua:202: test/functional/ui/screen.lua:324: Add Screen:_handle_curs
stack traceback:
	test/functional/helpers.lua:202: in function 'run'
	test/functional/ui/screen.lua:284: in function 'wait'
	test/functional/ui/screen.lua:213: in function 'expect'
	...is/build/neovim/neovim/test/functional/ui/spell_spec.lua:38: in function <...is/build/neovim/neovim/test/functional/ui/spell_spec.lua:27>
-- Output to stderr:
Uncaught Error: .../nvim-deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:84: invalid msgpack-rpc string
stack traceback:
	[C]: in function 'receive'
	.../nvim-deps/usr/share/lua/5.

Highlight _handle_curs which likely means stream was corrupted right after first 4 bytes in update name. Ref #8102

@bfredl bfredl merged commit 56065bb into neovim:master Jul 12, 2018

1 of 3 checks passed

QuickBuild Build pr-8721 finished with status FAILED
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@justinmk justinmk removed the RFC label Jul 12, 2018

justinmk added a commit that referenced this pull request Jul 18, 2018

NVIM v0.3.1
FEATURES:
07499a8 #8709 man.vim: C highlighting for EXAMPLES section
07f82ad #8699 TUI: urxvt: also send xterm focus-reporting seqs
40911e4 #8616 API: emit nvim_buf_lines_event from :terminal
c46997a #8546 fillchars: Add "eob" flag

FIXES:
74d19f6 #8576 startup: avoid blank stdin buffer if other files were opened
4874214 #8737 Only waitpid() for processes that we care about
cd6e7e8 #8743 Check all child processes for exit in SIGCHLD handler
c230ef2 #8746 channel.c: Prevent channel_destroy_early() from freeing uninitialized rpc stuff
0ed8b12 #8681 transstr_buf: fix length comparison
d241f27 #8708 TUI: Fix standout mode
9afed40 #8698 man.vim: fix for mandoc
e889640 #8682 provider/node: npm --loglevel silent
1cbc830 #8613 API: nvim_win_set_cursor: set curswant
bf6048e #8628 checkhealth: Python: fix VIRTUAL_ENV check
3cc3506 #8528 checkhealth: node.js: also search yarn

CHANGES:
b751449 #8619 defaults: shortmess+=F
1248178 #8578 highlight: high-priority CursorLine if fg is set.
01570f1 #8726 terminal: handle &confirm and :confirm on unloading
56065bb #8721 screen: truncate showmode messages
bf2460e #7551 buffer: fix copying :setlocal options
c1c14fa #8520 Ex mode: always "improved" (gQ)
050f397 #7992 options: remove 'maxcombine` option (always 6)

INTERNAL:
463da84 #7992 screen: use UTF-8 representation

UtkarshMe added a commit to UtkarshMe/neovim that referenced this pull request Jul 28, 2018

NVIM v0.3.1
FEATURES:
07499a8 neovim#8709 man.vim: C highlighting for EXAMPLES section
07f82ad neovim#8699 TUI: urxvt: also send xterm focus-reporting seqs
40911e4 neovim#8616 API: emit nvim_buf_lines_event from :terminal
c46997a neovim#8546 fillchars: Add "eob" flag

FIXES:
74d19f6 neovim#8576 startup: avoid blank stdin buffer if other files were opened
4874214 neovim#8737 Only waitpid() for processes that we care about
cd6e7e8 neovim#8743 Check all child processes for exit in SIGCHLD handler
c230ef2 neovim#8746 channel.c: Prevent channel_destroy_early() from freeing uninitialized rpc stuff
0ed8b12 neovim#8681 transstr_buf: fix length comparison
d241f27 neovim#8708 TUI: Fix standout mode
9afed40 neovim#8698 man.vim: fix for mandoc
e889640 neovim#8682 provider/node: npm --loglevel silent
1cbc830 neovim#8613 API: nvim_win_set_cursor: set curswant
bf6048e neovim#8628 checkhealth: Python: fix VIRTUAL_ENV check
3cc3506 neovim#8528 checkhealth: node.js: also search yarn

CHANGES:
b751449 neovim#8619 defaults: shortmess+=F
1248178 neovim#8578 highlight: high-priority CursorLine if fg is set.
01570f1 neovim#8726 terminal: handle &confirm and :confirm on unloading
56065bb neovim#8721 screen: truncate showmode messages
bf2460e neovim#7551 buffer: fix copying :setlocal options
c1c14fa neovim#8520 Ex mode: always "improved" (gQ)
050f397 neovim#7992 options: remove 'maxcombine` option (always 6)

INTERNAL:
463da84 neovim#7992 screen: use UTF-8 representation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment