Skip to content

fix: use exepath on server command - #2595

Merged
glepnir merged 1 commit into
neovim:masterfrom
glepnir:imp
May 9, 2023
Merged

glepnir merged 1 commit into
neovim:masterfrom
glepnir:imp

Conversation

@glepnir

@glepnir glepnir commented May 8, 2023

Copy link
Copy Markdown
Member

Fix #2130

@glepnir glepnir changed the title fix: auto add cmd.exe to server cmd when in windows fix: use exepath on server command May 9, 2023
@glepnir
glepnir merged commit 4a69ad6 into neovim:master May 9, 2023
@glepnir
glepnir deleted the imp branch May 9, 2023 07:10
@Decodetalkers

Decodetalkers commented May 9, 2023 •

Copy link
Copy Markdown
Contributor

gdscript is not changed , and seems

            cmd =  vim.lsp.rpc.connect('127.0.0.1', '9257') ,

is not allowed now

I don't know how to handle vim.lsp.rpc.connect now

maybe can let only table to expand? and not table it should be lua function?

@justinmk

Copy link
Copy Markdown
Member

This is a nice cleanup, thanks @glepnir .

This also shows the cost of allowing special-case features in the configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

append ".cmd" to command arg0 if it fails on Windows

3 participants