perf(gopls): lazy cache initialization #2671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine, prior to this patch, gopls requires more than 38ms to
load (even after multiple starts of neovim):
```
077.729 038.355 038.355: require('lspconfig.server_configurations.gopls')
```
while the other servers take tens of millisecond.
After implementing this change, gopls takes about the same time as the
others:
```
033.563 000.163 000.163: require('lspconfig.server_configurations.gopls')
```
I have tried to replace `go env GOMODCACHE` with
`echo /home/cjoly/go/pkg/mod` but it’s just as slow. I suspect that the
call to `system()` is so slow because I use the fish shell. If I change
the 'shell' setting to 'sh', the issue disappears. Nonetheless, it’s
probably worth fixing, since this change is not very complex IMO, even
if my configuration is somewhat exotic.
I’ve checked that this change does not make using the 'sh' shell slower
and that the LSP still initializes properly.
|
if this command have performance issue can make it async in root_dir . |
|
I have make it async in #2673 could you test it |
|
Just seen your second comment, thank you! Yes, your solution in #2673 does fix the issue as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, prior to this patch, gopls requires more than 38ms to
load (even after multiple starts of neovim):
while the other servers take tens of millisecond.
After implementing this change, gopls takes about the same time as the
others:
I have tried to replace
go env GOMODCACHEwithecho /home/cjoly/go/pkg/modbut it’s just as slow. I suspect that thecall to
system()is so slow because I use the fish shell. If I changethe 'shell' setting to 'sh', the issue disappears. Nonetheless, it’s
probably worth fixing, since this change is not very complex IMO, even
if my configuration is somewhat exotic.
I’ve checked that this change does not make using the 'sh' shell slower
and that the LSP still initializes properly.