Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet module (wrapper) #25

Open
gsmachado opened this issue May 15, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@gsmachado
Copy link
Member

commented May 15, 2019

As a developer, I would like to have a different module in neow3j that will act as a NEO wallet convenience layer. This module should be called wallet, that people can import using maven.

Tasks / Requirements:

  • Create a wallet java module
  • Provide a file-based database layer, to persist information (like a DAO)
  • Provide methods to get all past activity related to the wallet (e.g., performed transactions related to NEO, GAS, and other NEP-5 assets, when addresses were added, etc.)

The wallet module is intended to connect to one (or more) NEO nodes to perform JSON-RPC calls and get block information relevant for the addresses in the wallet. This information consists for example of UTXOs or transaction outputs for GAS claiming.
The wallet module, therefore, requires a file-based database (to be defined) in order to keep the wallets past activities (history).
It relies only on JSON-RPC nodes of version 2.10.2 and higher. It does not depend on other APIs, like the one of a neoscan server.

Features will be specified on different issues and might be referenced.

@claudemiller

This comment has been minimized.

Copy link
Member

commented May 31, 2019

As of neo-cli version 2.10.2, there are new JSON-RPC methods that allow the retrieval of claimable GAS and unspent transaction outputs for any address. This removes the need for scanning the blockchain and persisting such information locally in a database. Neow3j will make use of the new RPC methods to retrieve such information. The issue description has been modified accordingly.

claudemiller added a commit that referenced this issue Jun 20, 2019

#25:
- Change Wallet and Account creation to a more congurent Builder pattern.
- Store private and public key directly on the account instead of credentials (provides better overview of the account when used e.g. for asset transfers).
- Add Balances to account.
- Provide a response interceptor for mocking RPC node responses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.