Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt transaction model to Neo 3 #97

Open
csmuller opened this issue Oct 17, 2019 · 0 comments
Open

Adapt transaction model to Neo 3 #97

csmuller opened this issue Oct 17, 2019 · 0 comments
Assignees
Labels

Comments

@csmuller
Copy link
Member

@csmuller csmuller commented Oct 17, 2019

The transaction model has changed in Neo 3. The transaction types have been unified, so that only one transaction type exists. The data structure has also changed considerably. See the Neo3 Dev Guide for more information on the changes.

@csmuller csmuller added the neo3 label Oct 17, 2019
@csmuller csmuller self-assigned this Oct 17, 2019
csmuller added a commit that referenced this issue Oct 17, 2019
csmuller added a commit that referenced this issue Nov 29, 2019
The transaction classes should depend on the crypto primitives from
the crypto module, but are not themselves part of that module.
csmuller added a commit that referenced this issue Nov 29, 2019
The naming of for example RawScript should be changed to Witness to make it clear
what this scripts purpose is. It is not just some script but explicitely used as a witness.
Also remove "Raw" prefix from the transaction attributes.
csmuller added a commit that referenced this issue Nov 29, 2019
csmuller added a commit that referenced this issue Nov 29, 2019
csmuller added a commit that referenced this issue Nov 29, 2019
The nonce is a 32-bit unsigned integer in the neo C#
implementation and therefore can be better represented
by a positive long in Java. The value is bounded to the
range of a 32-bit unsigned int.
csmuller added a commit that referenced this issue Nov 29, 2019
Changed method names in BinaryWriter to reflect the exact primitve
type that they output. Added a new method to the writer that takes a long
and outputs a 32-bit unsigned integer needed for the nonce and
validUntilBlock property.
csmuller added a commit that referenced this issue Nov 30, 2019
csmuller added a commit that referenced this issue Nov 30, 2019
The toArray() method is only overwritten for adding the javadoc.
The behavior should still be the same as it is in the intefaces
default method.
csmuller added a commit that referenced this issue Nov 30, 2019
The ECPublicKey class is especially needed for the Cosigner class
but also adds a useful abstraction layer. The ECKeyPair class
needs to be reworked using this new abstraction.
csmuller added a commit that referenced this issue Nov 30, 2019
The set type makes testing the serialization hell because the sets
deny a fixed ordering of some of the properties.
csmuller added a commit that referenced this issue Nov 30, 2019
Same reasons as last commit but this time for the Transaction
class. This makes testing easier. The possibility that one might
add the same objects to the lists multiple times is ignored for
the moment.
csmuller added a commit that referenced this issue Dec 2, 2019
csmuller added a commit that referenced this issue Dec 2, 2019
The new exception bundles all the other possible exceptions that
can arise when deserializing neo3j objects.
csmuller added a commit that referenced this issue Dec 2, 2019
csmuller added a commit that referenced this issue Dec 2, 2019
csmuller added a commit that referenced this issue Dec 2, 2019
csmuller added a commit that referenced this issue Dec 7, 2019
csmuller added a commit that referenced this issue Dec 12, 2019
csmuller added a commit that referenced this issue Dec 12, 2019
gsmachado added a commit that referenced this issue Dec 19, 2019
gsmachado added a commit that referenced this issue Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.