tests(queue, worker): add unit tests

.editorconfig

@@ -0,0 +1,15 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+
+indent_style = space
+indent_size = 2
+
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = false

.gitignore

@@ -1 +1 @@
-node_modules/
+node_modules/

.jshintrc

@@ -0,0 +1,53 @@
+{
+  "bitwise": true,
+  "camelcase": false,
+  "curly": false,
+  "eqeqeq": true,
+  "es3": false,
+  "forin": true,
+  "immed": true,
+  "indent": 2,
+  "latedef": "nofunc",
+  "newcap": true,
+  "noarg": true,
+  "noempty": true,
+  "nonew": false,
+  "plusplus": false,
+  "quotmark": true,
+  "regexp": false,
+  "undef": true,
+  "unused": true,
+  "strict": true,
+  "trailing": true,
+  "maxparams": 5,
+  "maxdepth": 2,
+  "maxstatements": 30,
+  "maxcomplexity": 10,
+  "maxlen": 300,
+
+  "asi": false,
+  "boss": false,
+  "debug": false,
+  "eqnull": true,
+  "esnext": false,
+  "evil": false,
+  "expr": false,
+  "funcscope": false,
+  "globalstrict": false,
+  "iterator": false,
+  "lastsemic": false,
+  "laxbreak": false,
+  "laxcomma": false,
+  "loopfunc": false,
+  "moz": false,
+  "multistr": true,
+  "proto": false,
+  "scripturl": false,
+  "smarttabs": false,
+  "shadow": false,
+  "sub": false,
+  "supernew": false,
+  "validthis": true,
+
+  "node": true
+}

lib/driver/redis.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var redis = require('redis');
 
 /**
@@ -59,6 +61,16 @@ RedisDriver.prototype.hset = function (worker, key, data, callback) {
   this.client.hset(this.getCompleteWorkerName(worker), key, data, callback);
 };
 
+/**
+ * Get a data in the worker
+ * @param string worker Worker
+ * @param string key Key
+ * @param function callback Callback
+ */
+RedisDriver.prototype.hget = function (worker, key, callback) {
+  this.client.hget(this.getCompleteWorkerName(worker), key, callback);
+};
+
 /**
  * Get all property of a worker
  * @param string worker Worker

lib/queue.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 /**

lib/worker.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 var util = require('util');
 var EventEmitter = require('events').EventEmitter;
@@ -18,7 +20,7 @@ var EventEmitter = require('events').EventEmitter;
  */
 function Worker (queue, driver, name, action, options) {
   EventEmitter.call(this);
-  
+
   this.options = _.extend({
     type: 'FIFO',
     loopSleepTime: 0,
@@ -33,7 +35,7 @@ function Worker (queue, driver, name, action, options) {
   this.action = action;
   this.completeName = this.queue.getName() + ':' + name;
   this.initialized = false;
-};
+}
 
 util.inherits(Worker, EventEmitter);
 
@@ -122,7 +124,7 @@ Worker.prototype.start = function (callback) {
     this.setStatus(Worker.STATUS_STARTED, next);
 
     var endDate = new Date(Date.now() + (this.options.expire * 1000)).toJSON();
-    this.setEndDate(endDate);
+    this.setEndDate(endDate, _.noop);
   }, this));
 };
 
@@ -207,14 +209,14 @@ Worker.prototype.setStatus = function (status, callback) {
 
   var date = (new Date()).toJSON();
 
-  this.driver.hset(this.completeName, 'status_changedate', date);
+  this.driver.hset(this.completeName, 'status_changedate', date, _.noop);
 
   if (status === Worker.STATUS_WORKING)
     this.driver.hincrby(this.completeName, 'cpt_action', 1);
 
   if (status === Worker.STATUS_STARTED) {
-    this.driver.hset(this.completeName, 'cpt_action', 0);
-    this.driver.hset(this.completeName, 'start_date', date);
+    this.driver.hset(this.completeName, 'cpt_action', 0, _.noop);
+    this.driver.hset(this.completeName, 'start_date', date, _.noop);
   }
 };
 

package.json

@@ -27,7 +27,17 @@
   "dependencies": {
     "redis": "~0.8.3",
     "optimist": "~0.5.2",
-    "lodash": "~2.4.1"
+    "lodash": "^2.4.1",
+    "async": "^0.9.0",
+    "moment": "^2.6.0"
+  },
+  "devDependencies": {
+    "chai": "~1.7.2",
+    "mocha": "~1.13.0",
+    "sinon": "~1.7.3",
+    "sinon-chai": "~2.4.0",
+    "chai-things": "~0.2.0",
+    "proxyquire": "~0.5.2"
   },
   "licence": "MIT"
-}
+}

test/.jshintrc

@@ -0,0 +1,76 @@
+{
+  "bitwise": true,
+  "camelcase": false,
+  "curly": false,
+  "eqeqeq": true,
+  "es3": false,
+  "forin": true,
+  "immed": true,
+  "indent": 2,
+  "latedef": "nofunc",
+  "newcap": true,
+  "noarg": true,
+  "noempty": true,
+  "nonew": true,
+  "plusplus": false,
+  "quotmark": true,
+  "regexp": false,
+  "undef": true,
+  "unused": true,
+  "strict": false,
+  "trailing": true,
+  "maxparams": false,
+  "maxdepth": 2,
+  "maxstatements": 0,
+  "maxcomplexity": 10,
+  "maxlen": 110,
+  "globals": {
+    "describe": false,
+    "it": false,
+    "after": false,
+    "afterEach": false,
+    "before": false,
+    "beforeEach": false,
+    "define": false,
+    "xit": false,
+    "xdescribe": false,
+    "window": false,
+    "document": false,
+    "inject": false,
+    "mocha": false,
+    "$": false,
+    "requirejs": false,
+    "angular": false,
+    "sinon": true,
+    "expect": true,
+    "chai": true,
+    "e2e": true,
+    "app": true,
+    "localStorage": false
+  },
+  "asi": false,
+  "boss": false,
+  "debug": false,
+  "eqnull": true,
+  "esnext": false,
+  "evil": false,
+  "expr": true,
+  "funcscope": false,
+  "globalstrict": false,
+  "iterator": false,
+  "lastsemic": false,
+  "laxbreak": false,
+  "laxcomma": false,
+  "loopfunc": false,
+  "moz": false,
+  "multistr": true,
+  "proto": false,
+  "scripturl": false,
+  "smarttabs": false,
+  "shadow": false,
+  "sub": false,
+  "supernew": false,
+  "validthis": false,
+  "node": true,
+  "-W024": false
+}

test/bootstrap.js

@@ -0,0 +1,16 @@
+// chai
+chai = require('chai');
+expect = chai.expect;
+chai.Assertion.includeStack = true;
+
+// sinon
+sinon = require('sinon');
+chai.use(require('sinon-chai'));
+chai.use(require('chai-things'));
+
+var base = __dirname + '/../lib/';
+
+app = {
+  base: base,
+  config: require('./config')
+};

test/config.js

@@ -0,0 +1,9 @@
+module.exports = {
+  redis: {
+    run: {
+      host: 'localhost',
+      port: 6379
+    },
+    db: 12
+  }
+};