From 1b9af0e417c13bff0ad2113108465e6d3345df38 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mor=C3=A1vek?= <petr@pada.cz>
Date: Sat, 4 Feb 2023 10:07:17 +0100
Subject: [PATCH] tests: Ignore intentionally missing return types in fixtures

---
 phpstan.tests.neon.dist                          | 16 ++++++++++++++++
 .../HandleMethodHasNoReturnTypeHandler.php       |  4 ++--
 ...HasNullReturnTypeOnSomethingValidHappened.php |  4 ++--
 3 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/phpstan.tests.neon.dist b/phpstan.tests.neon.dist
index 2882bf3..82c3a16 100644
--- a/phpstan.tests.neon.dist
+++ b/phpstan.tests.neon.dist
@@ -31,6 +31,22 @@ parameters:
             message: "#^Parameter \\#1 \\$type of static method Nepada\\\\MessageBus\\\\StaticAnalysis\\\\HandlerType\\<Symfony\\\\Component\\\\Messenger\\\\Handler\\\\MessageHandlerInterface\\>\\:\\:fromString\\(\\) expects class\\-string\\<Symfony\\\\Component\\\\Messenger\\\\Handler\\\\MessageHandlerInterface\\>, string given\\.$#"
             count: 1
             path: tests/MessageBus/StaticAnalysis/Events/EventSubscriberValidatorTest.phpt
+        - # intentional for tests
+            message: "#^Method NepadaTests\\\\MessageBus\\\\StaticAnalysis\\\\Commands\\\\Fixtures\\\\HandleMethodHasNoReturnTypeHandler\\:\\:__invoke\\(\\) has no return type specified\\.$#"
+            count: 1
+            path: tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php
+        - # intentional for tests
+            message: "#^Method NepadaTests\\\\MessageBus\\\\StaticAnalysis\\\\Events\\\\Fixtures\\\\HandleMethodHasNullReturnTypeOnSomethingValidHappened\\:\\:__invoke\\(\\) has no return type specified\\.$#"
+            count: 1
+            path: tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php
+        - # intentional for tests
+            message: "#^Missing native return typehint (never|void)#"
+            count: 1
+            path: tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php
+        - # intentional for tests
+            message: "#^Missing native return typehint (never|void)$#"
+            count: 1
+            path: tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php
         -
             message: "#^Parameter \\#1 \\$callback of function array_map expects \\(callable\\(array\\<Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\>\\|Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\StampInterface\\)\\: mixed\\)\\|null, Closure\\(Symfony\\\\Component\\\\Messenger\\\\Stamp\\\\HandledStamp\\)\\: string given\\.$#"
             count: 1
diff --git a/tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php b/tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php
index 01a5891..5efe572 100644
--- a/tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php
+++ b/tests/MessageBus/StaticAnalysis/Commands/Fixtures/HandleMethodHasNoReturnTypeHandler.php
@@ -9,12 +9,12 @@ final class HandleMethodHasNoReturnTypeHandler implements CommandHandler
 {
 
     /**
+     * @phpcsSuppress SlevomatCodingStandard.TypeHints.ReturnTypeHint
      * @param ValidCommand $command
-     * @return mixed
      */
     public function __invoke(ValidCommand $command)
     {
-        return null;
+        throw new \Exception();
     }
 
 }
diff --git a/tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php b/tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php
index 2e9fb60..37c0a68 100644
--- a/tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php
+++ b/tests/MessageBus/StaticAnalysis/Events/Fixtures/HandleMethodHasNullReturnTypeOnSomethingValidHappened.php
@@ -9,12 +9,12 @@ final class HandleMethodHasNullReturnTypeOnSomethingValidHappened implements Eve
 {
 
     /**
+     * @phpcsSuppress SlevomatCodingStandard.TypeHints.ReturnTypeHint
      * @param SomethingValidHappenedEvent $event
-     * @return mixed
      */
     public function __invoke(SomethingValidHappenedEvent $event)
     {
-        return null;
+        throw new \Exception();
     }
 
 }