From 219432c1c15904c4033b48e4eff1f9f4c235238b Mon Sep 17 00:00:00 2001 From: Szymon Sadkowski <33400587+szysad@users.noreply.github.com> Date: Tue, 12 Mar 2024 14:59:23 +0100 Subject: [PATCH] remove deprecation warnings in fetch_runs_table() (#1686) Co-authored-by: Szymon Sadkowski --- CHANGELOG.md | 1 + src/neptune/metadata_containers/project.py | 6 ------ src/neptune/metadata_containers/utils.py | 8 -------- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe735d08b..816339cdd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ ### Changes - Improve dependency installation checking ([#1670](https://github.com/neptune-ai/neptune-client/pull/1670)) - Cache dependencies check ([#1675](https://github.com/neptune-ai/neptune-client/pull/1675)) +- Remove deprecation warning in `fetch_runs_table()` ([#1686](https://github.com/neptune-ai/neptune-client/pull/1686)) ## neptune 1.9.1 diff --git a/src/neptune/metadata_containers/project.py b/src/neptune/metadata_containers/project.py index cbc219a95..e2e857e57 100644 --- a/src/neptune/metadata_containers/project.py +++ b/src/neptune/metadata_containers/project.py @@ -45,7 +45,6 @@ from neptune.metadata_containers.abstract import NeptuneObjectCallback from neptune.metadata_containers.utils import ( build_raw_query, - deprecated_func_arg_warning_check, prepare_nql_query, ) from neptune.table import Table @@ -291,11 +290,6 @@ def fetch_runs_table( https://docs.neptune.ai/api/project#fetch_runs_table """ - deprecated_func_arg_warning_check("fetch_runs_table", "id", id) - deprecated_func_arg_warning_check("fetch_runs_table", "state", state) - deprecated_func_arg_warning_check("fetch_runs_table", "owner", owner) - deprecated_func_arg_warning_check("fetch_runs_table", "tag", tag) - if any((id, state, owner, tag)) and query is not None: raise ValueError( "You can't use the 'query' parameter together with the 'id', 'state', 'owner', or 'tag' parameters." diff --git a/src/neptune/metadata_containers/utils.py b/src/neptune/metadata_containers/utils.py index 1b086c6eb..f4cd32626 100644 --- a/src/neptune/metadata_containers/utils.py +++ b/src/neptune/metadata_containers/utils.py @@ -22,7 +22,6 @@ from datetime import datetime from typing import ( - Any, Generator, Iterable, List, @@ -31,7 +30,6 @@ ) from neptune.common.warnings import ( - NeptuneDeprecationWarning, NeptuneWarning, warn_once, ) @@ -175,12 +173,6 @@ def _parse_entry(entry: LeaderboardEntry) -> LeaderboardEntry: return entry -def deprecated_func_arg_warning_check(fname: str, vname: str, var: Any) -> None: - if var is not None: - msg = f"""The argument '{vname}' of the function '{fname}' is deprecated and will be removed in the future.""" - warn_once(msg, exception=NeptuneDeprecationWarning) - - def build_raw_query(query: str, trashed: Optional[bool]) -> NQLQuery: raw_nql = RawNQLQuery(query)