diff --git a/packages/nbextension/neptune-notebook.js b/packages/nbextension/neptune-notebook.js index 51ec6c86..77dc5dcc 100644 --- a/packages/nbextension/neptune-notebook.js +++ b/packages/nbextension/neptune-notebook.js @@ -168,7 +168,7 @@ define([ $.ajax({ url: 'https://pypi.org/pypi/neptune-notebooks/json', success: function (data) { - const latestVersion = Object.keys(data.releases).sort().pop(); + const latestVersion = Object.keys(data.releases).sort(sortVersion).pop(); if (CURRENT_VERSION !== latestVersion) { $('#neptune-upgrade-notice').show(); } @@ -177,6 +177,19 @@ define([ }) } + function sortVersion(a, b) { + var partsA = a.split('.'); + var partsB = b.split('.'); + for (var i = 0; i < 3; i++) { + var numberA = parseInt(partsA[i], 10); + var numberB = parseInt(partsB[i], 10); + if (numberA !== numberB) { + return numberA - numberB; + } + } + return 0; + } + function getAccessToken(status, apiToken, callback, errorCallback) { var decodedToken = {}; try {