Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10.2 and Swift 5.1 #64

Merged
merged 14 commits into from Oct 22, 2019
Merged

Xcode 10.2 and Swift 5.1 #64

merged 14 commits into from Oct 22, 2019

Conversation

@JosephDuffy
Copy link
Contributor

JosephDuffy commented Jul 6, 2019

I have branched off of #63 to (hopefully) fix CI, and add support for Swift 5.1 on Linux (by importing FoundationNetworking, as per https://forums.swift.org/t/foundationnetworking/24769)

tiferrei and others added 14 commits Mar 26, 2019
Some networking has been moved to FoundationNetworking on linux, see https://forums.swift.org/t/foundationnetworking/24769
This might be causing `swift` to not be found, although I am not sure
@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Oct 8, 2019

Hey I would like to help with this PR, I need this for Danger as well, is there something I can do to help this PR to get merged?

@f-meloni f-meloni mentioned this pull request Oct 14, 2019
@pietbrauer

This comment has been minimized.

Copy link
Member

pietbrauer commented Oct 22, 2019

@f-meloni I waited a long time but seems that this is not moving forward.

I would definitely take what @JosephDuffy has already done and move everything straight to Swift 5.1 and Xcode 11 on Travis.

@pietbrauer pietbrauer closed this Oct 22, 2019
@pietbrauer pietbrauer reopened this Oct 22, 2019
@pietbrauer pietbrauer merged commit da24ae1 into nerdishbynature:master Oct 22, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
WIP Legacy commit status override — see details
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pietbrauer

This comment has been minimized.

Copy link
Member

pietbrauer commented Oct 22, 2019

Hah, seems I was super confused by the WIP plugin and thought the build was failing. Sorry about that. Thanks a lot @JosephDuffy!

@f-meloni do you need more for danger else I would make a release?

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Oct 22, 2019

I think this should be ok!
Thank you very much @pietbrauer 🚀

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Nov 4, 2019

Hey @pietbrauer did you release a new version of RequestKit?

@pietbrauer

This comment has been minimized.

Copy link
Member

pietbrauer commented Nov 6, 2019

@f-meloni I did now, yes.

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Nov 6, 2019

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.