SSL+camo support!#1
Merged
galeone merged 10 commits intonerdzeu:masterfrom Oct 7, 2015
winterthediplomat:master
Merged
Conversation
It seems that adding `ssl on;` and `ssl_certificate*` just works (cit). Added automated copying of certs and custom nginx-reverse-proxy, but needs more work to make it really automagic (tl;dr done but commented)
docker-camo is now integrated inside docker-compose, and has a dedicated reverse proxy block. yay.
Separate README into sections, add troubleshooting. autosetup does not put certs and custom nginx-reverse-proxy in the correct folder automatically: the procedure is well explained in the README, and everyone can modify it as needed.
Member
|
Awesome work. I'm going to merge it right now. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL and camo are now available out of the box. Configuration docs are available in the readme.
SSL: adding
ssl on;andssl_certificate_*directives just works. Nerdz' self-signed certificates have been used during testing. I did not try if it works with cloudflare, though.camo: it's just an HTTP proxy to an internal service listening on port 8081.
ssldirectives are needed as we want to serve content via HTTPS.