Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer crash #3064

Closed
jb-ye opened this issue Apr 10, 2024 · 3 comments
Closed

Viewer crash #3064

jb-ye opened this issue Apr 10, 2024 · 3 comments

Comments

@jb-ye
Copy link
Collaborator

jb-ye commented Apr 10, 2024

Describe the bug

I am training splatfacto, during which I open the viewer. In the viewer, I tried to reset the resolution from default 512 to 1024, I got the above crash and the viewer basically freeze. It happens during early stage of training when coarse-to-fine training is active.

Exception in thread Thread-11:
Traceback (most recent call last):
  File "/opt/conda/envs/nerfstudio/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/eames-efs/eames-nerf/jianboye/projects/nerfstudio/nerfstudio/viewer/render_state_machine.py", line 222, in run
    outputs = self._render_img(action.camera_state)
  File "/eames-efs/eames-nerf/jianboye/projects/nerfstudio/nerfstudio/viewer/render_state_machine.py", line 182, in _render_img
    scale = min(desired_depth_pixels / current_depth_pixels, 1.0)
ZeroDivisionError: division by zero
@kerrj
Copy link
Collaborator

kerrj commented Apr 11, 2024

@brentyi This seems related to the depth rendering scaling factor

@brentyi
Copy link
Collaborator

brentyi commented Apr 11, 2024

Yeah, the error implies we're getting 0 from current_depth_pixels = outputs["depth"].shape[0] * outputs["depth"].shape[1]. Probably there's an edge case in _calculate_image_res, or how client camera aspect ratios are read/used?

@ichsan2895
Copy link

It also happen to me with same exact error message...

jb-ye pushed a commit to jb-ye/nerfstudio that referenced this issue May 1, 2024
jb-ye pushed a commit to jb-ye/nerfstudio that referenced this issue May 1, 2024
jb-ye added a commit to jb-ye/nerfstudio that referenced this issue May 1, 2024
jb-ye added a commit to jb-ye/nerfstudio that referenced this issue May 1, 2024
@kerrj kerrj closed this as completed in 3c4c3ae May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants