architecture(web): init #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
requested changes
Mar 13, 2019
web/README.md
Outdated
| @@ -1,3 +1,17 @@ | |||
| # CKB Explorer Web | |||
| # introduction | |||
There was a problem hiding this comment.
introduction to Introduction
web/README.md
Outdated
| CKB block explorer web | ||
| # Build Setup | ||
|
|
||
| prerequisite: nodejs |
There was a problem hiding this comment.
better to indicate version of NodeJS
web/README.md
Outdated
|
|
||
| yarn i | ||
|
|
||
| yarn start // for development |
There was a problem hiding this comment.
comments in shell should start with #
web/src/App.tsx
Outdated
| @@ -0,0 +1,55 @@ | |||
| import React, { useContext, useEffect } from 'react' | |||
| import Routers from './routes' | |||
| import Loading from './components/loading' | |||
There was a problem hiding this comment.
Component File should be named PascalCase
There was a problem hiding this comment.
Agree. Component name should be PascalCase
web/src/App.tsx
Outdated
| appContext.resize(window.innerWidth, window.innerHeight) | ||
| } | ||
| window.addEventListener('resize', resizeListener) | ||
| // appContext.toastMessage('hello', 12999933) |
web/src/components/loading/index.tsx
Outdated
| return ( | ||
| <LoadingDiv className="loading"> | ||
| <div | ||
| className="loading_content" |
There was a problem hiding this comment.
class name should follow the camelCase or BEMlink
duanyytop
reviewed
Mar 14, 2019
web/public/manifest.json
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "short_name": "React App", | |||
| "name": "Create React App Sample", | |||
There was a problem hiding this comment.
short_name and name should be CKB Explorer
duanyytop
approved these changes
Mar 15, 2019
shaojunda
added a commit
that referenced
this pull request
Oct 5, 2019
feat: change nonce precision to 50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.