Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: W^X initial implementation #53

Merged
merged 2 commits into from May 15, 2019

Conversation

@xxuejie
Copy link
Member

commented May 14, 2019

This adds initial W^X implementation to CKB VM. The actual syscall for tweaking page permissions is left for a future PR.

Note this also fixes a memory overflow situation in the assembly based interpreter

@xxuejie xxuejie requested review from quake and doitian May 14, 2019

@xxuejie

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Closing for now since this is a breaking change, will think of a better way for handling compatibility

@xxuejie xxuejie closed this May 14, 2019

@xxuejie xxuejie reopened this May 15, 2019

@janx janx changed the title feat: W^X initial implementation [HOLD] feat: W^X initial implementation May 15, 2019

@nervos-bot
Copy link

left a comment

Hold as requested by @janx.

@janx

janx approved these changes May 15, 2019

definitions/src/memory.rs Outdated Show resolved Hide resolved

@janx janx changed the title [HOLD] feat: W^X initial implementation feat: W^X initial implementation May 15, 2019

@nervos-bot nervos-bot bot dismissed their stale review May 15, 2019

Unhold as requested by @janx.

@jjyr

jjyr approved these changes May 15, 2019

@xxuejie xxuejie merged commit b260621 into nervosnetwork:develop May 15, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@xxuejie xxuejie deleted the xxuejie:wxorx branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.