Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT mode changes #96

Merged

Conversation

@xxuejie
Copy link
Member

xxuejie commented Feb 7, 2020

This PR made the following changes:

  • feat: Share memory write checking code in AOT mode(fixes #91)
  • fix: Bound checking bug in AOT mode

Note that AOT mode is not yet used in CKB, we can fix the bug in AOT mode directly. ASM mode will have to wait till the next hardfork.

xxuejie added 2 commits Feb 7, 2020
Note AOT mode is not yet used in CKB, we are free to change it here
@xxuejie xxuejie requested a review from nervosnetwork/ckb-code-review as a code owner Feb 7, 2020
@xxuejie xxuejie requested a review from zhangsoledad Feb 7, 2020
@doitian doitian added this to 👀 Awaiting review in CKB - Pull Requests Feb 10, 2020
@doitian doitian requested review from driftluo and removed request for zhangsoledad Feb 17, 2020
CKB - Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved Feb 18, 2020
@xxuejie xxuejie merged commit ec88d3d into nervosnetwork:develop Feb 18, 2020
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
nervosnetwork.ckb-vm Build #20200211.1 succeeded
Details
nervosnetwork.ckb-vm (UnitTest) UnitTest succeeded
Details
nervosnetwork.ckb-vm (UnitTestAllFeatures) UnitTestAllFeatures succeeded
Details
CKB - Pull Requests automation moved this from ✅ Reviewer approved to Done Feb 18, 2020
@xxuejie xxuejie deleted the xxuejie:share-write-checking-code-in-aot-mode branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.