Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide the implementation details #1541

Merged

Conversation

@yangby-cryptape
Copy link
Contributor

commented Sep 4, 2019

Use interfaces is better than use the implementation details.

@yangby-cryptape yangby-cryptape requested a review from nervosnetwork/ckb-code-review as a code owner Sep 4, 2019
@nervos-bot

This comment has been minimized.

Copy link

commented Sep 4, 2019

@driftluo is assigned as the chief reviewer

@u2
u2 approved these changes Sep 4, 2019
@u2
u2 approved these changes Sep 4, 2019
@quake
quake approved these changes Sep 4, 2019
@yangby-cryptape

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2019
1540: test: make a unit test more flexible r=quake a=yangby-cryptape

To fill the line number and column number is a terrible thing.

1541: chore: hide the implementation details r=yangby-cryptape a=yangby-cryptape

Use interfaces is better than use the implementation details.

1543: chore: reject malformed message asap, don't verify them r=quake a=yangby-cryptape

We can reject malformed messages from network asap.

Co-authored-by: Boyu Yang <yangby@cryptape.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Build succeeded

  • continuous-integration/travis-ci/push
@bors bors bot merged commit ca5df38 into nervosnetwork:develop Sep 4, 2019
4 of 5 checks passed
4 of 5 checks passed
nervosnetwork.ckb Build #20190904.33 failed
Details
Dummy CI CI that does nothing
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
nervosnetwork.ckb (UnitTest) UnitTest succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.