Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block serialized size should not include uncles proposals serialized size #1559

Merged

Conversation

@yangby-cryptape
Copy link
Contributor

commented Sep 6, 2019

No description provided.

…ized size
@yangby-cryptape yangby-cryptape requested a review from nervosnetwork/ckb-code-review as a code owner Sep 6, 2019
@quake
quake approved these changes Sep 6, 2019
@yangby-cryptape

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

bors r=zhangsoledad,quake

bors bot added a commit that referenced this pull request Sep 6, 2019
1557: test: add some tests back: lost some tests when replace `ckb-core` by `ckb-types` r=zhangsoledad,quake a=yangby-cryptape



1559: fix: block serialized size should not include uncles proposals serialized size r=zhangsoledad,quake a=yangby-cryptape



Co-authored-by: Boyu Yang <yangby@cryptape.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Build succeeded

  • continuous-integration/travis-ci/push
@bors bors bot merged commit 9bfdf33 into nervosnetwork:develop Sep 6, 2019
5 checks passed
5 checks passed
Dummy CI CI that does nothing
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
nervosnetwork.ckb Build #20190906.26 succeeded
Details
nervosnetwork.ckb (UnitTest) UnitTest succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.