Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve uncles hash calculation issue #1707

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@quake
Copy link
Member

quake commented Oct 11, 2019

Uncles hash is the blake2b on concatenated uncle block hashes.

@quake quake requested a review from nervosnetwork/ckb-code-review as a code owner Oct 11, 2019
@u2
u2 approved these changes Oct 12, 2019
@doitian doitian added this to the v0.24.0 milestone Oct 12, 2019
@doitian

This comment has been minimized.

Copy link
Member

doitian commented Oct 12, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 12, 2019
Merge #1707
1707: fix: resolve uncles hash calculation issue r=doitian a=quake

Uncles hash is the blake2b on concatenated uncle block hashes.

Co-authored-by: quake wang <quake.wang@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Oct 12, 2019

Build succeeded

  • continuous-integration/travis-ci/push
@bors bors bot merged commit c176773 into develop Oct 12, 2019
6 checks passed
6 checks passed
Dummy CI CI that does nothing
Details
License Compliance All checks passed.
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
nervosnetwork.ckb Build #20191011.22 succeeded
Details
nervosnetwork.ckb (UnitTest) UnitTest succeeded
Details
@bors bors bot deleted the quake/fix-uncles-hash branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.