Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neuron-ui): optimize pagination ui #135

merged 3 commits into from Mar 7, 2019


None yet
2 participants
Copy link

commented Mar 6, 2019

add ellipsis in pagination

@Keith-CY Keith-CY requested a review from ashchan Mar 6, 2019


const TablePagination = ({ total, currentPage, pageSize, displayCount = 5, onChange }: TablePaginationProps) => {

This comment has been minimized.

Copy link

ashchan Mar 7, 2019


I feel this component deserves its own file under widgets.

This comment has been minimized.

Copy link

Keith-CY Mar 7, 2019

Author Collaborator

Yes, I'll do it in another PR

Keith-CY added some commits Mar 7, 2019

Merge pull request #4 from Keith-CY/set-table-as-widget
refactor(neuron-ui): set table as widget

ashchan approved these changes Mar 7, 2019

@ashchan ashchan merged commit 1d43712 into nervosnetwork:develop Mar 7, 2019

@Keith-CY Keith-CY deleted the Keith-CY:optimize-pagination branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.