Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0021] Propose a CKB address format #100

Merged
merged 28 commits into from
Sep 12, 2019
Merged

Conversation

CipherWang
Copy link
Contributor

Thanks to github's 500 error, I have to recreate a new PR for CKB address format discussion.

Co-Authored-By: CipherWang <37256659+CipherWang@users.noreply.github.com>
@ashchan ashchan changed the title Propose a CKB address format, again Propose a CKB address format May 31, 2019
type = 0 / type = 1 mismatched in example.
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assign RFC# 21

@doitian doitian changed the title Propose a CKB address format [0021] Propose a CKB address format Jun 24, 2019
janx
janx previously requested changes Jun 24, 2019
Copy link
Member

@janx janx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update number and category (should be in Standards Track).

@doitian doitian dismissed their stale review July 19, 2019 09:01

RFC# assigned

@CipherWang
Copy link
Contributor Author

Question: should we change the lock_hash format from blake256 to blake160 (leading 20 bytes of blake256)? It reduces address length dramatically without sacrifying security, since we use secp256k1 + blake160 as the default lock script.

Here is a length comparison between 256bit and 160bit lock hash for address.

256bit: ckb1qrxl9wt772fhrff5st8ew7kqcyceeshpqtn2eqv9a9eu3xvkkn40wv6tu2p
160bit: ckb1qrxl9wt772fhrff5st8ew7kqcyceeshpqgvgvdkq <= 19bytes shorter!

@CipherWang
Copy link
Contributor Author

Please update number and category (should be in Standards Track).

updated.

@CipherWang
Copy link
Contributor Author

  1. remove lock_hash type address
  2. add full lock script address support, and remove 90 characters limit of Bech32
  3. compatible with previous address format

Co-Authored-By: Jan Xie <jan.h.xie@gmail.com>
Copy link
Member

@janx janx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the file/directory names should be changed to reflect correct rfc number;
  • please also add a row for this rfc in README

@CipherWang
Copy link
Contributor Author

  • the file/directory names should be changed to reflect correct rfc number;
  • please also add a row for this rfc in README

done, please review again.

@janx janx merged commit fc8e163 into nervosnetwork:master Sep 12, 2019
@ashchan
Copy link
Contributor

ashchan commented Sep 12, 2019

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants