-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0021] Propose a CKB address format #100
Conversation
merge from base
merge from original source
Co-Authored-By: CipherWang <37256659+CipherWang@users.noreply.github.com>
type = 0 / type = 1 mismatched in example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assign RFC# 21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update number and category (should be in Standards Track).
Co-Authored-By: Jan Xie <jan.h.xie@gmail.com>
Co-Authored-By: Jan Xie <jan.h.xie@gmail.com>
Question: should we change the lock_hash format from blake256 to blake160 (leading 20 bytes of blake256)? It reduces address length dramatically without sacrifying security, since we use secp256k1 + blake160 as the default lock script. Here is a length comparison between 256bit and 160bit lock hash for address. 256bit: ckb1qrxl9wt772fhrff5st8ew7kqcyceeshpqtn2eqv9a9eu3xvkkn40wv6tu2p |
updated. |
|
Co-Authored-By: Jan Xie <jan.h.xie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the file/directory names should be changed to reflect correct rfc number;
- please also add a row for this rfc in README
done, please review again. |
🍻 |
Thanks to github's 500 error, I have to recreate a new PR for CKB address format discussion.