Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0022] Informational: CKB Transaction Structure #134

Merged
merged 4 commits into from Dec 30, 2019
Merged

Conversation

@doitian
Copy link
Member

doitian commented Aug 26, 2019

[PREVIEW]

Updated for v0.25.0

@doitian doitian requested review from nervosnetwork/ckb-dev and ashchan Aug 26, 2019
@janx

This comment was marked as outdated.

Copy link
Member

janx commented Aug 27, 2019

Please use rfc number 0021 and add a row into readme.

@doitian doitian force-pushed the transaction-structure branch from 5f29070 to 891dfc0 Aug 27, 2019
@doitian doitian force-pushed the transaction-structure branch from 891dfc0 to c95e938 Aug 27, 2019
@doitian doitian changed the title Informational: CKB Transaction Structure [0021] Informational: CKB Transaction Structure Sep 4, 2019
@doitian doitian changed the title [0021] Informational: CKB Transaction Structure [0022] Informational: CKB Transaction Structure Sep 4, 2019
@doitian

This comment has been minimized.

Copy link
Member Author

doitian commented Sep 4, 2019

Please use rfc number 0021 and add a row into readme.

Changed to 0022 since 0021 was assigned to #100

@ashchan

This comment has been minimized.

Copy link
Member

ashchan commented Sep 9, 2019

Updated preview link.

@doitian doitian changed the title [0022] Informational: CKB Transaction Structure [HOLD] [0022] Informational: CKB Transaction Structure Oct 15, 2019
Copy link

nervos-bot bot left a comment

Hold as requested by @doitian.

@knwang knwang force-pushed the master branch from 17c738d to 0fafbbe Oct 22, 2019
@doitian doitian force-pushed the transaction-structure branch 2 times, most recently from e9c5730 to 900b6e6 Nov 15, 2019
@doitian doitian changed the title [HOLD] [0022] Informational: CKB Transaction Structure [0022] Informational: CKB Transaction Structure Nov 15, 2019
@nervos-bot nervos-bot bot dismissed their stale review Nov 15, 2019

Unhold as requested by @doitian.

@doitian doitian added this to 👀 Awaiting review in CKB Pull Requests Nov 26, 2019
@stwith

This comment has been minimized.

Copy link
Contributor

stwith commented Dec 10, 2019

Line 113 the “code cell out point” should be “code cell‘s out_point”, right?

doitian added 2 commits Aug 26, 2019
@doitian doitian force-pushed the transaction-structure branch from fc1aee2 to 354c881 Dec 11, 2019
@doitian

This comment has been minimized.

Copy link
Member Author

doitian commented Dec 11, 2019

Line 113 the “code cell out point” should be “code cell‘s out_point”, right?

Added 's to make it more clear.

The original ones are two informal.
@doitian doitian requested a review from quake Dec 27, 2019
@doitian doitian requested a review from janx Dec 27, 2019
@janx
janx approved these changes Dec 27, 2019
CKB Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved Dec 27, 2019
@janx janx merged commit 810bddc into master Dec 30, 2019
CKB Pull Requests automation moved this from ✅ Reviewer approved to Done Dec 30, 2019
@janx janx deleted the transaction-structure branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
7 participants
You can’t perform that action at this time.