Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't require child elements to alias to themselves #330

Closed
databyte opened this Issue Sep 18, 2012 · 5 comments

Comments

Projects
None yet
4 participants
Collaborator

databyte commented Sep 18, 2012

The following will return ""->[] "sometimes".

object @foo

child :elements do
  attributes :id
end

You have to do this instead:

object @foo

child :elements => :elements do
  attributes :id
end

Fix it. (I'm talking to myself.)

@databyte databyte was assigned Sep 18, 2012

Owner

nesquena commented Sep 18, 2012

Oh yeah this is a longstanding issue since you can also have the case:

object @foo

child @elements do
  attributes :id
end

Note the @elements where you genuinely might need the explicit declaration if the set is empty. In the case you bring up though, we have additional knowledge not being used that could potentially be used to avoid the awkward :foo => :foo case

I'd also really like this, fork'd and grep'ing for where I fix this.

👍

If you're not going to fix please at least document it. I keep running into this and each time I do I've forgotten the issue exists.

Owner

nesquena commented Sep 3, 2013

I think that this has been fixed in recent versions (try 0.9.0.pre). Let me know otherwise.

@nesquena nesquena closed this Sep 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment