Remove multi_json? #334

Closed
databyte opened this Issue Sep 25, 2012 · 7 comments

Projects

None yet

5 participants

@databyte
Collaborator

Based on this commit in Resque, I think @steveklabnik has a valid point. On the "Big v1" update, should we remove another dependency?

@steveklabnik

I know that @headius has done a good job keeping JSON in JRuby, and @evanphx said that using JSON is the right thing for Rubinius, too.

@nesquena
Owner

Yeah it's a valid point, I could definitely see the value of removing that dep

@nirvdrum

I'm late to this party. The JSON gem is fine, but has hard-coded limitations on depth that other providers don't have. JrJackson would probably be the most optimized JSON lib for JRuby and has support in multi_json. multi_json has already been removed, but I wanted to comment on that for historical record.

@nesquena
Owner

multi_json has been gone for a while in favor of using oj.

@nesquena nesquena closed this Sep 3, 2013
@headius

oj has no working gem under JRuby, so I guess this means rabl won't work on JRuby anymore?

@nesquena
Owner

I anticipated that issue which is why if Oj is not loaded then it will fallback to using JSON directly: https://github.com/nesquena/rabl/blob/master/lib/rabl/configuration.rb#L80 so it should still be working with RABL. In other words, if oj is loaded, rabl will use it but it doesn't require it.

@headius

Schweet, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment