New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move or remove manualtests in testsuites #302

Closed
heplesser opened this Issue Apr 11, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@heplesser
Copy link
Contributor

heplesser commented Apr 11, 2016

The main and the topology testsuites currently contain tests that need to be run manually. In practice, this means that they are hardly ever run and quickly become outdated, see comment in #221.

Those tests should preferably be converted to proper unit or regression tests, or, where that would be impossible, removed. Removal appears preferable to keeping dead code around.

@jakobj

This comment has been minimized.

Copy link
Contributor

jakobj commented May 12, 2016

one of the outdated manualtests seems to be "testsuite/manualtests/test_stdp_dopa.py", which does not seem to produce the desired behaviour:

expected weight at T=1000 ms: 28.6125 pA
weight at last event: 0.0 pA
@heplesser

This comment has been minimized.

Copy link
Contributor

heplesser commented Jun 30, 2017

Manual topology tests are now included in the testsuite per #705. Other manual test are addressed in the context of #348. I therefore close this issue.

@heplesser heplesser closed this Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment