Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Updates recording of currents provided by stimulating devices #720
This is a continuation of the discussion towards the end of #663.
The following needs to be updated:
One outstanding issue is possibly regarding the current generated by AC source. Consider the following:
The values that are computed are:
min_delay = 1.0
Shouldn't the value at t = 5.0, be I = 1000.00.... i.e. offset + sin(t=0).
The absence of this value (1000.0) in NEST, I believe, causes a more abrupt change in both the current and voltage at the start of current injection as seen below, which is absent in the next cycle (starting at 15 ms). The change in Vm is more gradual in case of Brian and NEURON (as seen in the values above).
@heplesser , @gtrensch : Any thoughts on this? My current workaround for this is to compensate for the jump by adjusting the phase appropriately. But I believe there should be a more elegant fix, if this is infact considered an issue with the AC source.
@gtrensch : I have pulled the changes from your repository and updated L348 here:
Once we decide on the AC source, I shall create a pull request.