New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Parameter Name String in conn_builder.cpp #735

Closed
maharjun opened this Issue May 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@maharjun
Contributor

maharjun commented May 28, 2017

As of the latest master commit 15b63f2 (master branch), the file conn_builder.cpp at line '340' appears to mistakenly contain a space after the " in the parameter string " A_minus"

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser May 29, 2017

Contributor

@maharjun Thanks for reporting! That space seems to have been there for a while already, and it appears that that test is never executed. I have now removed the test entirely (see #736 for reasons) and added a regression test.

Contributor

heplesser commented May 29, 2017

@maharjun Thanks for reporting! That space seems to have been there for a while already, and it appears that that test is never executed. I have now removed the test entirely (see #736 for reasons) and added a regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment