New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion that prohibits simulation for 0 ms #778

Closed
heplesser opened this Issue Jul 4, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@heplesser
Contributor

heplesser commented Jul 4, 2017

#650 introduced an assertion to SimulationManager::run() that makes it impossible to simulate for zero time:

void
nest::SimulationManager::run( Time const& t )
{
  assert_valid_simtime( t );

  to_do_ += t.get_steps();
  to_do_total_ = to_do_;
  assert( to_do_ != 0 );

There is no reason to prohibit this, it should simply be a no-op. Therefore, the assertion should be replaced with return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment