Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regressiontests/ticket-659-copyright.py fails if NEST build directory is in source directory #911

Closed
alberto-antonietti opened this issue Mar 15, 2018 · 2 comments
Assignees
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation ZC: Installation DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL

Comments

@alberto-antonietti
Copy link
Contributor

I noticed that if NEST is built in a folder inside the source directory (e.g. nest-simulator/b ), the test done by ticket-659-copyright fails because of the headers that are not correctly ignored.

`Running test 'regressiontests/ticket-659-copyright.py'...

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/libc_allocator_with_realloc.h':
expected -> '/*', actual -> '// Copyright (c) 2010, Google Inc.'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/mt19937.h':
expected -> '/*', actual -> '#ifndef MT19937_H'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/type_traits.h':
expected -> '/*', actual -> '// Copyright (c) 2006, Google Inc.'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/template_util.h':
expected -> '/*', actual -> '// Copyright 2005 Google Inc.'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/hashtable-common.h':
expected -> '/*', actual -> '// Copyright (c) 2010, Google Inc.'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/knuthlfg.h':
expected -> '/*', actual -> '#ifndef KNUTHLFG_H'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/sparseconfig.h':
expected -> '* sparseconfig.h', actual -> '* NOTE: This file is for internal use only.'

Incorrect copyright header in '/home/alberto/nest-simulator/b/include/nest/sparsetable.h':
expected -> '/*', actual -> '// Copyright (c) 2005, Google Inc.'

Files with errors '8' out of '2122'!
-> 20 (Failed: inconsistent copyright header(s))`

This is a minor issue, but I can easily fix the code of ticket-659-copyright to avoid the failure in case someone builds NEST inside the nest source directory.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation ZC: Installation DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 16, 2018
@heplesser
Copy link
Contributor

@alberto-antonietti We generally recommend against building NEST in the source directory, but since we do not explicitly prevent it, building should work correctly. It would be great if you could provide a pull request to fix this.

alberto-antonietti added a commit to alberto-antonietti/nest-simulator that referenced this issue Mar 19, 2018
alberto-antonietti added a commit to alberto-antonietti/nest-simulator that referenced this issue Mar 19, 2018
jougs added a commit that referenced this issue Apr 6, 2018
@jougs
Copy link
Contributor

jougs commented Apr 6, 2018

Closed by #914.

@jougs jougs closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation ZC: Installation DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Development

No branches or pull requests

3 participants