New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pointless comparison with uint #1000

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
4 participants
@ikitayama
Contributor

ikitayama commented Aug 9, 2018

This patch silences the warnings observed with FCC on the K computer login node:

"/.../nest-simulator/nestkernel/connector_base.h", line 283: warning: pointless comparison of unsigned integer with zero
      assert( lcid >= 0 and lcid < C_.size() );
                   ^

"/.../nest-simulator/nestkernel/mpi_manager.h", line 567: warning: pointless comparison of unsigned integer with zero
    assert( chunk_size_in_int >= 0 );
                              ^
Silence warnings from FCC - just stop doing pointless comparison
of unsigned integer with zero as the compiler warns.

@heplesser heplesser requested a review from jakobj Aug 9, 2018

@ikitayama ikitayama changed the title from Silence warnings from FCC to Removing pointless comparison with uint Aug 9, 2018

@ikitayama

This comment has been minimized.

Show comment
Hide comment
@ikitayama

ikitayama Aug 9, 2018

Contributor

Thanks to @heplesser for suggesting the title change.

Contributor

ikitayama commented Aug 9, 2018

Thanks to @heplesser for suggesting the title change.

@ikitayama

This comment has been minimized.

Show comment
Hide comment
@ikitayama

ikitayama Aug 16, 2018

Contributor

@heplesser, @jakobj seems to be busy with something, as this fix is very easy to review, would you go ahead do that and merge it? This is easily detected and warned, and produces threw of outputs by most toolchains.

Contributor

ikitayama commented Aug 16, 2018

@heplesser, @jakobj seems to be busy with something, as this fix is very easy to review, would you go ahead do that and merge it? This is easily detected and warned, and produces threw of outputs by most toolchains.

@heplesser heplesser requested review from clinssen and stinebuu and removed request for jakobj Aug 16, 2018

@clinssen

thumbs up, index is typedef'd as size_t so check for nonnegativity is pointless

@stinebuu

stinebuu approved these changes Aug 16, 2018 edited

Looks good! Also, congratulations on landing issue/PR 1000! 🎉

@ikitayama

This comment has been minimized.

Show comment
Hide comment
@ikitayama

ikitayama Aug 16, 2018

Contributor

Although I am new to here, I am so proud of the record-breaking 1000th landing.

Contributor

ikitayama commented Aug 16, 2018

Although I am new to here, I am so proud of the record-breaking 1000th landing.

@heplesser heplesser merged commit a82538a into nest:master Aug 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment