Add ostream operator template for std::vectors #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terhorstd: you can either fix the format of the code you're proposing or start another PR to change the formatting guidelines as discussed two weeks ago and to make your code pass the tests. Both options would be fine for me at this point in time. |
terhorstd
added
T: Enhancement
heplesser
requested changes
Mar 13, 2019
There was a problem hiding this comment.
@terhorstd Good idea, but see my comments in the code. In contrast to @jougs, I'd ask you to format the code according to our current guidelines.
heplesser
requested changes
Apr 9, 2019
| { | ||
| os << ", "; | ||
| } | ||
| os << element; |
There was a problem hiding this comment.
@terhorstd Don't you need to set first to false somewhere?
heplesser
approved these changes
Jun 4, 2019
heplesser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming
std::vectors just streams all elements (given that the elements supportcout << obj;). This is very useful in many circumstances and should not be implemented each time anew.