Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This PR contains our joint effort on refactoring the kernel of NEST. Beside one public API change, the appearance and behavior of NEST should remain unchanged. The refactoring contains:
I hope I did not miss any changes. I invite you all (@nest/nest-developers) to review and test this PR. @janhahne please see that the gap junctions work as expected. @sdiazpier and @naveau please see that the structural plasticity is working as expected.
… into ConnectionBuilderManager Conflicts: nestkernel/network.cpp
…iables from Network class to NodeManager, adapted function calls in all scripts
I just compiled NEST3 with
@tammoippen How should I best contribute small fixes, such as missing newlines at end of file?
@sdiazpier Clang points out (correctly) that
@sdiazpier Clang also issues the following warning:
@jougs Clang warns about a few deprecated MPI-2 names:
Unfortunately, several tests fail:
Finally the testsuite hangs forever on Running test 'regressiontests/ticket-80-175-179.sli'...
I haven't had time to investigate.
Please create a PR onto my Fork. I will merge ASAP.
Some of these tests also fail for NEST 2.10.0 on OS X with clang. I think there is a specific issue with this combination (on Linux with clang I did not observe any of these issues).
I have explored the test failures a bit further (all with
Tests coming after