Replacing internal C++ variable U0_ by E_L. #236

Merged
merged 6 commits into from Mar 11, 2016

Conversation

Projects
None yet
3 participants
@jougs
Contributor

jougs commented Feb 19, 2016

Most neuron models use the internal variable U0_ for the resting potential. The user interface uses the name E_L to conform to our policy of using Dyan&Abbot terminology wherever possible.

This is confusing and this pull request replaces U0_ by E_L_ and thus makes code, comments and UI wording consistent.

I suggest @heplesser and @tammoippen as reviewers.

@tammoippen

This comment has been minimized.

Show comment
Hide comment
@tammoippen

tammoippen Feb 20, 2016

Contributor

👍 from my side! Nice. Do you think, we need to adjust the examples as well? There U0 is used a lot as a local variable.

Contributor

tammoippen commented Feb 20, 2016

👍 from my side! Nice. Do you think, we need to adjust the examples as well? There U0 is used a lot as a local variable.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Feb 21, 2016

Contributor

Yes, probably we should also change the examples. I'll look into this.

Contributor

jougs commented Feb 21, 2016

Yes, probably we should also change the examples. I'll look into this.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Feb 29, 2016

Contributor

@jougs This seems to make a lot of sense. I trust no U0 is left in the code now? Have you run all the examples to make sure that everything still works?

Contributor

heplesser commented Feb 29, 2016

@jougs This seems to make a lot of sense. I trust no U0 is left in the code now? Have you run all the examples to make sure that everything still works?

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Mar 9, 2016

Contributor

@heplesser: I can confirm that U0 is gone from NEST completely. I've also run all examples using the run_examples.sh script provided in the examples directory and did not observe any problems.

Contributor

jougs commented Mar 9, 2016

@heplesser: I can confirm that U0 is gone from NEST completely. I've also run all examples using the run_examples.sh script provided in the examples directory and did not observe any problems.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 10, 2016

Contributor

👍 then for a U0-free world! Any U2 in NEST ;)?

Contributor

heplesser commented Mar 10, 2016

👍 then for a U0-free world! Any U2 in NEST ;)?

tammoippen added a commit that referenced this pull request Mar 11, 2016

Merge pull request #236 from jougs/replace_U0
Replacing internal C++ variable U0_ by E_L.

@tammoippen tammoippen merged commit 2341e1d into nest:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment