New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves documentation for regexec function, solving trac.560. #251

Merged
merged 1 commit into from Mar 7, 2016

Conversation

Projects
None yet
2 participants
@heplesser
Contributor

heplesser commented Mar 2, 2016

This PR improves the documentation of the regexec function in the regex SLI module. This should fix #560. The regex modules is used in a few places internally (SLI file system functions, unittests) and works fine, so I see no need for more work on that module.

@jougs Could you take a look at this?

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 2, 2016

Contributor

trac.560 should be closes as fixed once this PR is merged.

Contributor

heplesser commented Mar 2, 2016

trac.560 should be closes as fixed once this PR is merged.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Mar 7, 2016

Contributor

This looks good to me. I'm immediately merging and closing the old trac issue. Thanks for taking care!

Contributor

jougs commented Mar 7, 2016

This looks good to me. I'm immediately merging and closing the old trac issue. Thanks for taking care!

jougs added a commit that referenced this pull request Mar 7, 2016

Merge pull request #251 from heplesser/fix_regex_docs
Improves documentation for regexec function, solving trac.560.

@jougs jougs merged commit 57a27c9 into nest:master Mar 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:fix_regex_docs branch Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment