Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix80 check multiplicity handling #255

Merged
merged 4 commits into from Apr 25, 2016

Conversation

@heplesser
Copy link
Contributor

heplesser commented Mar 3, 2016

This PR allows spike_generator to emit spikes with multiplicity, which is essential for testing multiplicity-handling in neurons. It also adds a test to check that (almost) all neurons handle multiplicity of incoming spikes properly. This should fix #80.

heplesser added 2 commits Mar 3, 2016
…s mostly for debugging purposes.

- Added test that ensures that all models heed spike multiplicity.
@heplesser
Copy link
Contributor Author

heplesser commented Mar 3, 2016

@jougs @tammoippen Would you review?

spike_weights double array - corrsponding spike-weights, the unit depends on the receiver
spike_weights double array - corresponding spike-weights, the unit depends on the receiver
spike_multiplicities int array - multiplicities of spikes, same length as spike_times;
mostly for debugging

This comment has been minimized.

Copy link
@tammoippen

tammoippen Mar 21, 2016

Contributor

The comment formatting seems off here.

@tammoippen
Copy link
Contributor

tammoippen commented Mar 21, 2016

Very nice. 👍 from my side.

origin double - Time origin for device timer in ms
start double - earliest possible time stamp of a spike to be emitted in ms
stop double - earliest time stamp of a potential spike event that is not
emitted in ms

This comment has been minimized.

Copy link
@abigailm

abigailm Apr 18, 2016

Contributor

Are comments supposed to wrap like this, or should they be indented after the break?

# Conflicts:
#	models/spike_generator.cpp
#	models/spike_generator.h
@heplesser
Copy link
Contributor Author

heplesser commented Apr 25, 2016

@abigailm I merged the formatting changes from the master branch now and fixed the comment formatting. I hope you are now happy with the PR.

@abigailm abigailm merged commit 7263679 into nest:master Apr 25, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser heplesser deleted the heplesser:fix80_check_multiplicity_handling branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.