Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing #264: Raise exceptions on incommensurate times #265
@heplesser I guess it's a matter of taste. I took it as an indication that it was an input, when it's only an output variable, and hunted for where the initialization was necessary. If the following chunks are wrapped up into a convenience function, it goes away altogether.
So this rounds down from stimtime + 2 ms to the nearest grid, correct? Shouldn't this round up to the nearest grid, or is the 2ms supposed to be large enough to always go to the next biggest grid time for all test cases, which is then sufficient for all spikes to arrive at spike detector? If it's the latter, it would probably be good to add a comment by the tested cases in the assert or die regarding what is the maximum testable case value (0.1? 0.2?)