Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 101 Documentation of current filtering in iaf_psc_exp #276

Merged
merged 2 commits into from Mar 18, 2016

Conversation

@jschuecker
Copy link
Contributor

jschuecker commented Mar 13, 2016

This PR improves the documentation of the option for synaptic filtering of external current, available in iaf_psc_exp. This addresses #101 .

@heplesser, could you take a look at this?

@jschuecker jschuecker changed the title Fix 101 Review current input and its documentation in iaf_psc_exp Fix 101 Documentation of current filtering in iaf_psc_exp Mar 13, 2016
the synapse. Hereby the time constant of the post-synaptic
excitatory currents is used. This filtering can be used for a
direct implementation of the diffusion approximation, i.e.,
replacing incoming spike trains with white noise.

This comment has been minimized.

Copy link
@heplesser

heplesser Mar 14, 2016

Contributor

@jschuecker Thanks for the more detailed explanation. I would be yet more explicit, e.g.

"iaf_psc_exp can handle current input in two ways: Current input through receptor_type 0 are handled as stepwise constant current input as in other iaf models, i.e., this current directly enters the membrane potential equation. Current input through receptor_type 1, in contrast, is filtered through an exponential kernel with the time constant of the excitatory synapse, tau_syn_ex. For an example application, see [4; reference to paper inserted below]."

I am a bit concerned about the statement that this provides a "direct implementation ... with white noise". Since the noise generator generates stepwise constant input, the input is never really white noise, see doc/model_details/noise_generator.ipynb.

@jschuecker
Copy link
Contributor Author

jschuecker commented Mar 17, 2016

@heplesser, I meant "direct" in the sense of a "straight forward" implementation. But you are right, that was not clear and could be misleading. I also included the reference. Thanks!

heplesser added a commit that referenced this pull request Mar 18, 2016
Fix 101 Documentation of current filtering in iaf_psc_exp
@heplesser heplesser merged commit e1dd8a8 into nest:master Mar 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser
Copy link
Contributor

heplesser commented Mar 18, 2016

👍 and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.